Re: [Valgrind-developers] 64k pages on PPC

[Dave N. <dc...@us...>]

His patch is very similar to mine but includes some fixes for things 
that I hadn't figure out so I prefer his over mine.  Also, he addressed 
the issue of modifying vki-ppc{32,64}-linux.h by allowing for both 4K 
and 64K without introducing the run-time variable.  Instead, he just 
defined local variables in m_main.c called VKI_PAGE_SIZE/VKI_PAGE_SHIFT 
and initialized them from the ELF Auxillary table.

I tested his patch out on our RHEL5 ppc w/ 64k pagesize and it works 
just fine.

The only thing that is needed to make the regression suite run cleaner 
on glibc-2.5 is a new glibc-2.5.supp which is just a copy of glibc-2.4 
with the following addition:
{
  glibc-2.5-hack-1
  Memcheck:Cond
  obj:/lib*/ld-2.5.so
  obj:/lib*/ld-2.5.so
  obj:/lib*/ld-2.5.so
  obj:/lib*/ld-2.5.so
  obj:/lib*/ld-2.5.so
  obj:/lib*/ld-2.5.so
}

Please let me know if you are planning on pushing this upstream soon.  I 
am planning on pointing RedHat at this patch for their upcoming RHEL5 
release.

Nicholas Nethercote wrote:
> This bug report was added to the database:
>
> http://bugs.kde.org/show_bug.cgi?id=136300
>
> It seems to be addressing the same issue, and there's a patch.  I haven't 
> looked at it so I don't know how it compares to your code, but it might be 
> worthwhile looking at it.
>
> Nick
>
>
>