Re: [Valgrind-developers] 64k pages on PPC

[Dave N. <dc...@us...>]

His patch is very similar to mine but includes some fixes for things 
that I hadn't figure out so I prefer his over mine.  Also, he addressed 
the issue of modifying vki-ppc{32,64}-linux.h by allowing for both 4K 
and 64K without introducing the run-time variable.  Instead, he just 
defined local variables in m_main.c called VKI_PAGE_SIZE/VKI_PAGE_SHIFT 
and initialized them from the ELF Auxillary table.

Please let me know if you are planning on pushing this upstream soon.  I 
am planning on pointing RedHat at this patch for their upcoming RHEL5 
release.

The only thing that is needed to make the regression suite run cleaner 
on glibc-2.5 is a new glibc-2.5.supp which is just a copy of glibc-2.4 
with the following addition:
{
   glibc-2.5-hack-1
   Memcheck:Cond
   obj:/lib*/ld-2.5.so
   obj:/lib*/ld-2.5.so
   obj:/lib*/ld-2.5.so
   obj:/lib*/ld-2.5.so
   obj:/lib*/ld-2.5.so
   obj:/lib*/ld-2.5.so
}

Nicholas Nethercote wrote:
> This bug report was added to the database:
>
> http://bugs.kde.org/show_bug.cgi?id=136300
>
> It seems to be addressing the same issue, and there's a patch.  I haven't 
> looked at it so I don't know how it compares to your code, but it might be 
> worthwhile looking at it.
>
> Nick
>
>
> On Wed, 25 Oct 2006, Dave Nomura wrote:
>
>   
>> Julian Seward wrote:
>>     
>>> ----------
>>>
>>> I presume you'll be sending a patch for review at some point?
>>>
>>>       
>> yes, working on it.
>>
>> a couple of other issues:
>> 1. I am dealing with glibc version 2.5 so have already encountered 1
>> change needed in the default.supp file.
>> Do you have any recommendation about how to go about creating a new
>> glibc-2.5.supp?
>> start with glibc-2.4 and add stuff as needed?  start with an empty file?
>>
>> 2.  I am making changes to include/vki-ppc{32,64}-linux.h to make
>> VKI_PAGE_SHIFT and VKI_PAGE_SIZE dependent on initializiation of a
>> variable.  I notice that these files are installed and made available
>> for public consumption.  I initialize the variable that these #defines
>> depend on in valgrind, but a user that unwittingly uses them in a test
>> program would be referencing an uninitialized variable.
>>
>> How do you think we should handle this?
>> 1. Change valgrind to use different macros than the VKI_PAGE_* macros?
>> 2. put some #ifdef's around the ppc VKI_PAGE_* macros, with maybe the 4K
>> page size as the default, allow the 64K pagesize to be selected by
>> -DWANT_64K_PAGESIZE, or use the dynamic sizes required by Valgrind
>> controlled by something like -DWANT_DYNAMIC_PAGESIZE
>> 3. ???
>>
>>     
>>> ----------
>>>
>>> You should think about how to ensure the new functionality doesn't get
>>> broken in the future -- bearing in mind none (AFAIK) of the available
>>> test machines are ppc systems with 64k pages.  We know from experience
>>> that functionality which is not automatically tested tends to get
>>> broken over time.
>>>
>>> One effective solution is to run the nightly build system on your own
>>> 64k-page development box.  Another is to add regression tests; although
>>> I'm not sure how/what they would look like.
>>>
>>>       
>> I'm not sure how I would make specific regression tests either but will
>> plan on running the regression tests from time to time.
>>
>>
>>
>> -------------------------------------------------------------------------
>> Using Tomcat but need to do more? Need to support web services, security?
>> Get stuff done quickly with pre-integrated technology to make your job easier
>> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>> _______________________________________________
>> Valgrind-developers mailing list
>> Val...@li...
>> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>>
>>     
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>