Re: [Valgrind-developers] valgrind: r6320 - in trunk: . include

[Nicholas N. <nj...@cs...>]

On Wed, 18 Oct 2006 sv...@va... wrote:

> Author: njn
> Date: 2006-10-18 22:50:26 +0100 (Wed, 18 Oct 2006)
> New Revision: 6320
>
> Log:
> Move VG_BUGS_TO to pub_tool_basics.h so that Nulgrind need not import
> pub_tool_libcassert.h.

This was an incorrect log message.  It was meant to be "fix a couple of 
comments".

> Modified:
>   trunk/Makefile.am
>   trunk/configure.in
>   trunk/include/pub_tool_tooliface.h
>   trunk/include/valgrind.h
>
>
> Modified: trunk/Makefile.am
> ===================================================================
> --- trunk/Makefile.am	2006-10-18 12:41:55 UTC (rev 6319)
> +++ trunk/Makefile.am	2006-10-18 21:50:26 UTC (rev 6320)
> @@ -8,7 +8,8 @@
> 		callgrind \
> 		massif \
> 		lackey \
> -		none
> +		none \
> +		memtrace
>
> # Temporary: we want to compile Helgrind, but not regtest it.
> # Put docs last because building the HTML is slow and we want to get
>
> Modified: trunk/configure.in
> ===================================================================
> --- trunk/configure.in	2006-10-18 12:41:55 UTC (rev 6319)
> +++ trunk/configure.in	2006-10-18 21:50:26 UTC (rev 6320)
> @@ -931,6 +931,9 @@
>    none/tests/ppc64/Makefile
>    none/tests/x86/Makefile
>    none/docs/Makefile
> +   memtrace/Makefile
> +   memtrace/tests/Makefile
> +   memtrace/docs/Makefile
> )
>
> cat<<EOF
>
> Modified: trunk/include/pub_tool_tooliface.h
> ===================================================================
> --- trunk/include/pub_tool_tooliface.h	2006-10-18 12:41:55 UTC (rev 6319)
> +++ trunk/include/pub_tool_tooliface.h	2006-10-18 21:50:26 UTC (rev 6320)
> @@ -32,7 +32,7 @@
> #define __PUB_TOOL_TOOLIFACE_H
>
> #include "pub_tool_errormgr.h"   // for Error, Supp
> -#include "libvex.h"              // for VexGuestLayout
> +#include "libvex.h"              // for all Vex stuff
>
> /* ------------------------------------------------------------------ */
> /* The interface version */
>
> Modified: trunk/include/valgrind.h
> ===================================================================
> --- trunk/include/valgrind.h	2006-10-18 12:41:55 UTC (rev 6319)
> +++ trunk/include/valgrind.h	2006-10-18 21:50:26 UTC (rev 6320)
> @@ -3715,15 +3715,15 @@
>    for calloc().  Put it immediately after the point where a block is
>    allocated.
>
> -   If you're allocating memory via superblocks, and then handing out small
> -   chunks of each superblock, if you don't have redzones on your small
> -   blocks, it's worth marking the superblock with VALGRIND_MAKE_MEM_NOACCESS
> -   when it's created, so that block overruns are detected.  But if you can
> -   put redzones on, it's probably better to not do this, so that messages
> -   for small overruns are described in terms of the small block rather than
> -   the superblock (but if you have a big overrun that skips over a redzone,
> -   you could miss an error this way).  See memcheck/tests/custom_alloc.c
> -   for an example.
> +   If you're using Memcheck: If you're allocating memory via superblocks,
> +   and then handing out small chunks of each superblock, if you don't have
> +   redzones on your small blocks, it's worth marking the superblock with
> +   VALGRIND_MAKE_MEM_NOACCESS when it's created, so that block overruns are
> +   detected.  But if you can put redzones on, it's probably better to not do
> +   this, so that messages for small overruns are described in terms of the
> +   small block rather than the superblock (but if you have a big overrun
> +   that skips over a redzone, you could miss an error this way).  See
> +   memcheck/tests/custom_alloc.c for an example.
>
>    WARNING: if your allocator uses malloc() or 'new' to allocate
>    superblocks, rather than mmap() or brk(), this will not work properly --
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>