|
From: Julian S. <js...@ac...> - 2006-10-15 11:59:14
|
> > +/* Call this if a recognised option was bad for some reason. Note: > > + don't use it just because an option was unrecognised -- return > > + 'False' from VG_(tdict).tool_process_cmd_line_option) to indicate > > + that. This function prints an error message, then shuts down the > > + entire system. */ > > +extern void VG_(err_bad_option) ( Char* opt ); > > + > > +/* Similarly - complain that the executable is missing, then stop. */ > > +extern void VG_(err_missing_prog) ( void ); > > + > > +/* Similarly - complain about some config error. */ > > +extern void VG_(err_config_error) ( Char* msg ); > > Hmm, there isn't any reason why a tool should call err_missing_prog or > err_config_error... I think those two should stay in m_main.c. I see the > similarity between the three functions, perhaps that should be factored out > into another function. Hmm, that's a good point. Hadn't noticed that before. Alternatively err_missing_prog and err_config_error could be moved from the tool .h to the core .h -- what say you to that? J |