|
From: <sv...@va...> - 2006-08-28 22:57:04
|
Author: sewardj
Date: 2006-08-28 23:56:59 +0100 (Mon, 28 Aug 2006)
New Revision: 6040
Log:
Slacken assertion slightly, and add comments. Fixes #133051
('cfsi->len > 0 && cfsi->len < 2000000' failed)
Modified:
trunk/coregrind/m_debuginfo/storage.c
Modified: trunk/coregrind/m_debuginfo/storage.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_debuginfo/storage.c 2006-08-28 21:51:34 UTC (rev 60=
39)
+++ trunk/coregrind/m_debuginfo/storage.c 2006-08-28 22:56:59 UTC (rev 60=
40)
@@ -308,7 +308,13 @@
ML_(ppDiCfSI)(cfsi);
}
=20
- vg_assert(cfsi->len > 0 && cfsi->len < 2000000);
+ /* sanity */
+ vg_assert(cfsi->len > 0);
+ /* If this fails, the implication is you have a single procedure
+ with more than 5 million bytes of code. Which is pretty
+ unlikely. Either that, or the debuginfo reader is somehow
+ broken. */
+ vg_assert(cfsi->len < 5000000);
=20
/* Rule out ones which are completely outside the segment. These
probably indicate some kind of bug, but for the meantime ignore
|