|
From: Julian S. <js...@ac...> - 2006-05-01 01:42:59
|
> This explains the huge memory requirements of self-hosting > with outer callgrind. Using the new option should get rid of this. Excellent. > Should I add a tip to use "--pop-on-jump" with callgrind in the > self-hosting section of README_DEVELOPERS? Yes. > I will not document it otherwise, because it makes callgrind quite > unstable (something to investigate). Ok. If --pop-on-jump is not used, then callgrind's stability is unchanged, right? > --- m_dispatch/dispatch-x86-linux.S (Revision 5868) > +++ m_dispatch/dispatch-x86-linux.S (Arbeitskopie) > @@ -51,6 +51,7 @@ > */ > .text > .globl VG_(run_innerloop) > +.type VG_(run_innerloop), @function > VG_(run_innerloop): > /* 4(%esp) holds guest_state */ > /* 8(%esp) holds do_profiling */ > @@ -251,8 +252,8 @@ > popl %ecx > popl %ebx > ret > +.size VG_(run_innerloop), .-VG_(run_innerloop) Sounds good. Please commit it. J |