|
From: Eric P. <eri...@wa...> - 2006-02-13 20:25:22
|
Tom Hughes wrote: >>I dunno (I do have the same thoughts about it). My point was not to make >>a 100% accurate patch, but at least to show the areas that needed to be >>improved. IMO, the best solution would be not to ask for a RT signal >>handler if the user doesn't ask for (there's nothing to be done here, >>just passing the information), but it complicates a bit the signal >>handling code on V side. > > > I'm not sure I understand what you mean there - regardless of what > sort of handler valgrind asks the kernel for it should always be > presenting the right sort (rt or non-rt) of signal frame to the > application's handler. I was talking about the sig handler valgrinds asks for to the kernel. IMO, if we want to get the mappings 100% right from the kernel, we should do something like: - if the user asks for a non rt sig handler, vg should ask for a non rt sig handler - if the user asks for a rt sig handler, vg should ask for a rt sig handler of course, that would duplicate all the sig handler code A+ -- Eric Pouech |