|
From: Tom H. <to...@co...> - 2006-02-13 17:52:43
|
In message <43F...@wa...>
Eric Pouech <eri...@wa...> wrote:
> Tom Hughes wrote:
>
> > In message <43F...@wa...>
> > Eric Pouech <eri...@wa...> wrote:
> >
> > > 1/ trapno in sigframe (vg-trapno.diff)
> > > (already posted in the bug database, but enhanced from previous
> > > post). This patch sets the trapno field in sigframe structure.
> >
> > I did look at that bug yesterday but I'm not a big fan of your
> > solution and I'm trying to come up with a better approach.
> >
> > How accurate is the mapping you provided - given that you are trying
> > to go backwards from signal number/reason to trap number is that
> > actually a reversible mapping? or does the kernel map multiple trap
> > numbers to a single signal+reason combination in some cases?
>
> I dunno (I do have the same thoughts about it). My point was not to make
> a 100% accurate patch, but at least to show the areas that needed to be
> improved. IMO, the best solution would be not to ask for a RT signal
> handler if the user doesn't ask for (there's nothing to be done here,
> just passing the information), but it complicates a bit the signal
> handling code on V side.
I'm not sure I understand what you mean there - regardless of what
sort of handler valgrind asks the kernel for it should always be
presenting the right sort (rt or non-rt) of signal frame to the
application's handler.
> > > 3/ disabled support for tkill (vg-tkill.diff)
> > > This patch (partly) reenables tkill syscall under
> > > x86-linux. Basically, Wine is made to run either under (NPTL) pthread
> > > support, or old kernel thread support. We use tkill, which is
> > > transparent whatever the thread system we're running on (pthread or
> > > kthread).
> >
> > I think I've got your post in valgrind-users about this marked to
> > be looked at when I get a chance, but once again putting it on the
> > bug tracker is a better idea.
>
> Not sure I did post something to vg-users :-/
You're right, it was somebody else asking about tkill.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|