|
From: Robert W. <rj...@du...> - 2006-02-10 03:17:45
|
On Fri, 2006-02-10 at 14:15 +1100, Nicholas Nethercote wrote: > On Thu, 9 Feb 2006, Robert Walsh wrote: >=20 > >> It looks ok to me. My only reservation is - have you been able to > >> run tests to verify that said functionality still works post change? > > > > Well, all the current test suite still runs with no changes. Now > > whether that means the functionality is still being tested, I honestly > > can't say. >=20 > It's not -- that code is for the stabs symbol stuff that is only used by=20 > Helgrind. Well, that leaves me in a bit of a pickle, then. Since Helgrind is probably bitrotted by now, I'd say I should just check it in and we can fix it if it breaks anything later. That sound OK? --=20 Robert Walsh Amalgamated Durables, Inc. - "We don't make the things you buy." Email: rj...@du... |