|
From: Julian S. <js...@ac...> - 2005-11-18 17:22:20
|
> > Back out r5180 (sorry Josef). On consideration it just increases the > > difficulty of testing the system properly. > > What is/was the problem here? No particular problem, but 1. The redirect/no-redirect decision was made on the basis of whether the tool overrides malloc or not. This is not a good criterion -- for example it means the redirection is done for massif too. 2. It means there are more ways the system can break -- now we have some tools using these replacement fns and some tools not using them. To tell the truth I'm not really clear what problem callgrind has with them. They just replace strlen and strcmp when called from ld.so, but they don't replace the strlen and strcmp in glibc, so I would not expect them to come very high on the profiles. So what problem are they causing? > For meaningful results in the scope of redirections, I had to revert the > instrument function back to *not* use the noredir_addr. I hope this is > fine because I switch off chaising. Well, it might work, but it's not good. I wonder if there's a better way to solve this. J |