|
From: Nicholas N. <nj...@cs...> - 2005-11-17 19:23:34
|
On Wed, 16 Nov 2005, Robert Walsh wrote: >> I have no idea what stack_changes is testing - stack_switch I wrote >> to test that bug I committed the patch for last week. > > stack_changes is checking the libc context calls (setcontext, etc.) and > checks that Valgrind notices their stack changes properly. This has > nothing to do with the clone checks that you're doing in stack_switch. > Perhaps both names should be a bit more descriptive to describe their > functionality. Or some comments could be added at the top of the .c files. More comments in a lot of the regtests explaining what they are testing for would be welcome... some of them say "this is a regtest for bug #12345 which was causing failure X" which is good... Nick |