|
From: Nicholas N. <nj...@cs...> - 2005-11-17 19:21:31
|
On Thu, 17 Nov 2005, Tom Hughes wrote: >>> /* We make the data segment (heap) executable because LinuxThreads on >>> ppc32 creates trampolines in this area. */ >>> sres = VG_(am_mmap_anon_fixed_client)( >>> anon_start, >>> anon_size, >>> VKI_PROT_READ|VKI_PROT_WRITE|VKI_PROT_EXEC >>> ); >>> >>> only set EXEC for ppc32, using a "#if defined(ppc32)"? > > Like I said my x86 boxes don't have it executable, although that > can be open to variation due to x86 exec flag wierdness. My amd64 > boxes certainly don't have it executable. > > Killing programs that put executable code in the heap/stack is of > course exactly what operating systems are trying to do these days > in the name of security. So should the code or the comment be changed? I don't have strong opinions because I'm no expert on this kind of stuff, but I want to get it right because this kind of minor detail can be crucial. Nick |