|
From: Tom H. <to...@co...> - 2005-11-16 10:04:58
|
In message <200...@gm...>
Josef Weidendorfer <Jos...@gm...> wrote:
> On Wednesday 16 November 2005 08:13, Tom Hughes wrote:
>> In message <200...@gm...>
>> Josef Weidendorfer <Jos...@gm...> wrote:
>>
>> > On Wednesday 16 November 2005 01:09, sv...@va... wrote:
>> > > Reinstate code to extent SegInfo ranges to cover all PT_LOAD segments
>> > > when VG_(needs_data_syms) has been called by the tool.
>> >
>> > That was the patch fixing my problem, as I see.
>> >
>> > I do not really understand it, but callgrind is not
>> > setting VG_(needs_data_syms)... so the fix seems only to be about
>>
>> Yes it is - line 920 of main.c calls it.
>
> But this is done only with "--collect-data", which is an experimental
> option and not really working nowadays; ie. never used.
> There is no loss by removing it.
In which case my patch was a no-op for callgrind and shouldn't have
changed anything.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|