|
From: Josef W. <Jos...@gm...> - 2005-11-16 09:40:43
|
On Wednesday 16 November 2005 08:13, Tom Hughes wrote: > In message <200...@gm...> > Josef Weidendorfer <Jos...@gm...> wrote: > > > On Wednesday 16 November 2005 01:09, sv...@va... wrote: > > > Reinstate code to extent SegInfo ranges to cover all PT_LOAD segments > > > when VG_(needs_data_syms) has been called by the tool. > > > > That was the patch fixing my problem, as I see. > > > > I do not really understand it, but callgrind is not > > setting VG_(needs_data_syms)... so the fix seems only to be about > > Yes it is - line 920 of main.c calls it. But this is done only with "--collect-data", which is an experimental option and not really working nowadays; ie. never used. There is no loss by removing it. But perhaps it is the right point to discuss a needed tools API feature for this: --collect-data is supposed to keep access/cache miss counters per data structure, not per line. For static data, I need the address ranges of static symbols, from the symbol table. But it is way to slow to let VG look up the list of symbols at every memory access. So I once patched VG for another callback to build up a fast lookup table myself, at symbol reading time. OTOH, this fast table is probably better to be in VG core itself. If I get some time, I'll try to provide a patch. Josef |