|
From: Josef W. <Jos...@gm...> - 2005-11-15 23:27:08
|
On Tuesday 15 November 2005 21:34, Jeroen N. Witmond wrote: > I would like VG_(am_get_filename) to moved to the tool iface file, yes. I > don't understand about VG_(am_get_segname). The name of the segment is the > name of the file to which the segment is mapped, or from which the segment > was loaded; right? There is no VG_(am_get_segname) and there will be no need for it ;-) I didn't find VG_(am_get_filename) in pub_tool_aspacemgr.h, so I proposed a quite bad name for it (because the variable is called segname[]). I am not sure if I need it, but if tools already have access to ASpaceMgr, it is desirable to get the name of a mapped file, too. Julian: yes, please put VG_(am_get_filename) into pub_tool_aspacemgr.h. A wish regarding the tool interface for the future: it would be good to be able to get a string representation of a guest assembler instruction. This way, assembler annotation could be done by visualization tools without dependency on "objdump" and the executed binary. Two advantages: Profile data with assembler code of executed instructions is * more self-contained, i.e. I could copy profile data from the PPC machine to look at PPC assembler annotation on my (offline) laptop * the handling of comparing profile data before and after a code change is easier; at the moment, I need to have access to the old binaries; and if they get deleted (by make or whatever), assembler annotation is not possible any longer Josef |