|
From: <sv...@va...> - 2005-11-15 02:24:59
|
Author: njn Date: 2005-11-15 02:24:57 +0000 (Tue, 15 Nov 2005) New Revision: 5132 Log: Remove horribly out-of-date comment. Modified: trunk/memcheck/mc_main.c Modified: trunk/memcheck/mc_main.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/memcheck/mc_main.c 2005-11-14 17:03:54 UTC (rev 5131) +++ trunk/memcheck/mc_main.c 2005-11-15 02:24:57 UTC (rev 5132) @@ -98,29 +98,6 @@ //zz There are actually 4 distinguished secondaries. These are used = to //zz represent a memory range which is either not addressable (validi= ty //zz doesn't matter), addressable+not valid, addressable+valid. -//zz=20 -//zz [...] lots of stuff deleted due to out of date-ness -//zz=20 -//zz As a final optimisation, the alignment and address checks for -//zz 4-byte loads and stores are combined in a neat way. The primary -//zz map is extended to have 262144 entries (2^18), rather than 2^16. -//zz The top 3/4 of these entries are permanently set to the -//zz distinguished secondary map. For a 4-byte load/store, the -//zz top-level map is indexed not with (addr >> 16) but instead f(add= r), -//zz where -//zz=20 -//zz f( XXXX XXXX XXXX XXXX ____ ____ ____ __YZ ) -//zz =3D ____ ____ ____ __YZ XXXX XXXX XXXX XXXX or=20 -//zz =3D ____ ____ ____ __ZY XXXX XXXX XXXX XXXX -//zz=20 -//zz ie the lowest two bits are placed above the 16 high address bits= . -//zz If either of these two bits are nonzero, the address is misalign= ed; -//zz this will select a secondary map from the upper 3/4 of the prima= ry -//zz map. Because this is always the distinguished secondary map, a -//zz (bogus) address check failure will result. The failure handling -//zz code can then figure out whether this is a genuine addr check -//zz failure or whether it is a possibly-legitimate access at a -//zz misaligned address. =20 //zz */ =20 /* --------------- Basic configuration --------------- */ |