|
From: Nicholas N. <nj...@cs...> - 2005-11-02 15:26:03
|
On Wed, 2 Nov 2005, Tom Hughes wrote: >> Does the as_mmap test serve any purpose now? >> >> It tries to map a chunk of memory at various fixed addresses in >> memory - presumably the idea was to check that it couldn't map in >> the valgrind areas. Certainly both sets of expected results show >> it failing at the high addresses. >> >> With the address space manager there are no longer any real guarantees >> about which addresses might or might not be available and one of the >> areas that is expected to fail is actually working on amd64. > > Much the same applies to as_shm as well, which is trying to attach a > shared memory segment at a high address and expecting it to fail. Removing both sounds fine to me. Good job with cleaning up the regtests, Tom. A bad test is arguably worse than no test at all. Nick |