|
From: <sv...@va...> - 2005-10-20 01:57:35
|
Author: sewardj
Date: 2005-10-20 02:57:29 +0100 (Thu, 20 Oct 2005)
New Revision: 4957
Log:
Increase the threshold above which new errors are not shown from 300
unique / 30000 total to 1000 unique / 100000 total. Programs are
generally bigger now than 3 years ago.
Modified:
trunk/coregrind/m_errormgr.c
trunk/docs/valgrind.1
trunk/docs/xml/manual-core.xml
trunk/memcheck/tests/x86/scalar.stderr.exp
Modified: trunk/coregrind/m_errormgr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_errormgr.c 2005-10-20 01:37:15 UTC (rev 4956)
+++ trunk/coregrind/m_errormgr.c 2005-10-20 01:57:29 UTC (rev 4957)
@@ -51,16 +51,16 @@
=20
/* After this many different unsuppressed errors have been observed,
be more conservative about collecting new ones. */
-#define M_COLLECT_ERRORS_SLOWLY_AFTER 50
+#define M_COLLECT_ERRORS_SLOWLY_AFTER 100
=20
/* After this many different unsuppressed errors have been observed,
stop collecting errors at all, and tell the user their program is
evidently a steaming pile of camel dung. */
-#define M_COLLECT_NO_ERRORS_AFTER_SHOWN 300
+#define M_COLLECT_NO_ERRORS_AFTER_SHOWN 1000
=20
/* After this many total errors have been observed, stop collecting
errors at all. Counterpart to M_COLLECT_NO_ERRORS_AFTER_SHOWN. */
-#define M_COLLECT_NO_ERRORS_AFTER_FOUND 30000
+#define M_COLLECT_NO_ERRORS_AFTER_FOUND 100000
=20
/* The list of error contexts found, both suppressed and unsuppressed.
Initially empty, and grows as errors are detected. */
Modified: trunk/docs/valgrind.1
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/docs/valgrind.1 2005-10-20 01:37:15 UTC (rev 4956)
+++ trunk/docs/valgrind.1 2005-10-20 01:57:29 UTC (rev 4957)
@@ -137,8 +137,8 @@
.TP
.B
--error-limit=3D<yes|no> [default: yes]
-When enabled, \fBvalgrind\fP stops reporting errors after 30000 in total=
,
-or 300 different ones, have been seen. This is to stop the error trackin=
g
+When enabled, \fBvalgrind\fP stops reporting errors after 100000 in tota=
l,
+or 1000 different ones, have been seen. This is to stop the error tracki=
ng
machinery from becoming a huge performance overhead in programs with
many errors.
=20
Modified: trunk/docs/xml/manual-core.xml
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/docs/xml/manual-core.xml 2005-10-20 01:37:15 UTC (rev 4956)
+++ trunk/docs/xml/manual-core.xml 2005-10-20 01:57:29 UTC (rev 4957)
@@ -348,10 +348,10 @@
expensive one and can become a significant performance overhead
if your program generates huge quantities of errors. To avoid
serious problems here, Valgrind will simply stop collecting
-errors after 300 different errors have been seen, or 30000 errors
+errors after 1000 different errors have been seen, or 100000 errors
in total have been seen. In this situation you might as well
stop your program and fix it, because Valgrind won't tell you
-anything else useful after this. Note that the 300/30000 limits
+anything else useful after this. Note that the 1000/100000 limits
apply after suppressed errors are removed. These limits are
defined in <filename>m_errormgr.c</filename> and can be increased
if necessary.</para>
@@ -769,7 +769,7 @@
[default]</para>
<para><computeroutput>--error-limit=3Dno</computeroutput></para>
<para>When enabled, Valgrind stops reporting errors after
- 30000 in total, or 300 different ones, have been seen. This
+ 100000 in total, or 1000 different ones, have been seen. This
is to stop the error tracking machinery from becoming a huge
performance overhead in programs with many errors.</para>
</listitem>
Modified: trunk/memcheck/tests/x86/scalar.stderr.exp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/memcheck/tests/x86/scalar.stderr.exp 2005-10-20 01:37:15 UTC (r=
ev 4956)
+++ trunk/memcheck/tests/x86/scalar.stderr.exp 2005-10-20 01:57:29 UTC (r=
ev 4957)
@@ -330,9 +330,6 @@
by 0x........: __libc_start_main (in /...libc...)
by 0x........: ...
=20
-More than 50 errors detected. Subsequent errors
-will still be recorded, but in less detail than before.
-
Syscall param mount(source) points to unaddressable byte(s)
at 0x........: syscall (in /...libc...)
by 0x........: __libc_start_main (in /...libc...)
@@ -708,6 +705,9 @@
55: __NR_fcntl (GETLK) 1s 0m
-----------------------------------------------------
=20
+More than 100 errors detected. Subsequent errors
+will still be recorded, but in less detail than before.
+
Syscall param fcntl(lock) contains uninitialised byte(s)
at 0x........: syscall (in /...libc...)
by 0x........: __libc_start_main (in /...libc...)
|