|
From: <sv...@va...> - 2005-10-20 01:37:20
|
Author: sewardj
Date: 2005-10-20 02:37:15 +0100 (Thu, 20 Oct 2005)
New Revision: 4956
Log:
Remove all remaining references to pointercheck. It's sad to see it
go, but realistically we can't implement it portably, at least without
considerable performance overhead and some additional complexity.
Modified:
trunk/coregrind/m_main.c
trunk/coregrind/m_options.c
trunk/coregrind/m_signals.c
trunk/coregrind/pub_core_options.h
trunk/docs/valgrind.1
trunk/docs/xml/manual-core.xml
trunk/none/tests/cmdline1.stdout.exp
trunk/none/tests/cmdline2.stdout.exp
Modified: trunk/coregrind/m_main.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_main.c 2005-10-20 01:09:57 UTC (rev 4955)
+++ trunk/coregrind/m_main.c 2005-10-20 01:37:15 UTC (rev 4956)
@@ -885,7 +885,6 @@
" --run-libc-freeres=3Dno|yes free up glibc memory at exit? [yes]\n"
" --simulation-hints=3Dhint1,hint2,... known hints:\n"
" lax-ioctls, enable-outer [none]\n"
-" --pointercheck=3Dno|yes enforce client address space limits [ye=
s]\n"
" --show-emwarns=3Dno|yes show warnings about emulation limits? [=
no]\n"
" --smc-check=3Dnone|stack|all checks for self-modifying code: none,=
\n"
" only for code found in stacks, or all [st=
ack]\n"
@@ -1091,7 +1090,6 @@
else VG_BOOL_CLO(arg, "--db-attach", VG_(clo_db_attach))
else VG_BOOL_CLO(arg, "--demangle", VG_(clo_demangle))
else VG_BOOL_CLO(arg, "--error-limit", VG_(clo_error_limit))
- else VG_BOOL_CLO(arg, "--pointercheck", VG_(clo_pointercheck))
else VG_BOOL_CLO(arg, "--show-emwarns", VG_(clo_show_emwarns))
else VG_NUM_CLO (arg, "--max-stackframe", VG_(clo_max_stackframe=
))
else VG_BOOL_CLO(arg, "--profile", VG_(clo_profile))
@@ -2479,15 +2477,6 @@
}
=20
//--------------------------------------------------------------
- // Setup pointercheck
- // p: layout_remaining_space() [for VG_(client_{base,end})]
- // p: process_cmd_line_options() [for VG_(clo_pointercheck)]
- //--------------------------------------------------------------
- //if (VG_(clo_pointercheck))
- // VG_(clo_pointercheck) =3D
- // VG_(setup_pointercheck)( VG_(client_base), VG_(client_end));
-
- //--------------------------------------------------------------
// register client stack
//--------------------------------------------------------------
VG_(clstk_id) =3D VG_(register_stack)(VG_(clstk_base), VG_(clstk_end)=
);
Modified: trunk/coregrind/m_options.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_options.c 2005-10-20 01:09:57 UTC (rev 4955)
+++ trunk/coregrind/m_options.c 2005-10-20 01:37:15 UTC (rev 4956)
@@ -71,7 +71,6 @@
Bool VG_(clo_run_libc_freeres) =3D True;
Bool VG_(clo_track_fds) =3D False;
Bool VG_(clo_show_below_main)=3D False;
-Bool VG_(clo_pointercheck) =3D True;
Bool VG_(clo_model_pthreads) =3D False;
Bool VG_(clo_show_emwarns) =3D False;
Int VG_(clo_max_stackframe) =3D 2000000;
Modified: trunk/coregrind/m_signals.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_signals.c 2005-10-20 01:09:57 UTC (rev 4955)
+++ trunk/coregrind/m_signals.c 2005-10-20 01:37:15 UTC (rev 4956)
@@ -999,12 +999,8 @@
/* General Protection Fault: The CPU/kernel
isn't telling us anything useful, but this
is commonly the result of exceeding a
- segment limit, such as the one imposed by
- --pointercheck=3Dyes. */
- if (VG_(clo_pointercheck))
- event =3D "GPF (Pointer out of bounds?)";=20
- else
- event =3D "General Protection Fault";=20
+ segment limit. */
+ event =3D "General Protection Fault";=20
haveaddr =3D False;
break;
}
Modified: trunk/coregrind/pub_core_options.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/pub_core_options.h 2005-10-20 01:09:57 UTC (rev 4955)
+++ trunk/coregrind/pub_core_options.h 2005-10-20 01:37:15 UTC (rev 4956)
@@ -135,9 +135,6 @@
extern Bool VG_(clo_run_libc_freeres);
/* Continue stack traces below main()? Default: NO */
extern Bool VG_(clo_show_below_main);
-/* Test each client pointer dereference to check it's within the
- client address space bounds */
-extern Bool VG_(clo_pointercheck);
/* Model the pthread library */
extern Bool VG_(clo_model_pthreads);
=20
Modified: trunk/docs/valgrind.1
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/docs/valgrind.1 2005-10-20 01:09:57 UTC (rev 4955)
+++ trunk/docs/valgrind.1 2005-10-20 01:37:15 UTC (rev 4956)
@@ -486,14 +486,6 @@
=20
.TP
.B
---pointercheck=3D<yes|no> [default: yes]
-When enabled, enforces client address space limits. If this option is
-disabled, the client program has full and unfettered access to the part
-of the address space used internally by \fBvalgrind\fP. This can cause
-unexplained crashes and false error reports, so it is best left enabled.
-
-.TP
-.B
--run-libc-freeres=3D<yes|no> [default: yes]
The GNU C library (libc.so), which is used by all programs, may allocate=
=20
memory for its own uses. Usually it doesn't bother to free that memory w=
hen=20
Modified: trunk/docs/xml/manual-core.xml
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/docs/xml/manual-core.xml 2005-10-20 01:09:57 UTC (rev 4955)
+++ trunk/docs/xml/manual-core.xml 2005-10-20 01:37:15 UTC (rev 4956)
@@ -1034,19 +1034,6 @@
</itemizedlist>
</listitem>
=20
- <listitem id=3D"pointer_check">
- <para><computeroutput>--pointercheck=3Dyes</computeroutput> [default=
]</para>
- <para><computeroutput>--pointercheck=3Dno</computeroutput></para>
- <para>This option make Valgrind generate a check on every memory
- reference to make sure it is within the client's part of the
- address space. This prevents stray writes from damaging
- Valgrind itself. On x86, this uses the CPU's segmentation
- machinery, and has almost no performance cost; there's almost
- never a reason to turn it off. On the other architectures this=20
- option is currently ignored as they don't have a cheap way of achiev=
ing
- the same functionality.</para>
- </listitem>
-
<listitem id=3D"show_emwarns">
<para><computeroutput>--show-emwarns=3Dno</computeroutput> [default]=
</para>
<para><computeroutput>--show-emwarns=3Dyes</computeroutput></para>
Modified: trunk/none/tests/cmdline1.stdout.exp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/none/tests/cmdline1.stdout.exp 2005-10-20 01:09:57 UTC (rev 495=
5)
+++ trunk/none/tests/cmdline1.stdout.exp 2005-10-20 01:37:15 UTC (rev 495=
6)
@@ -20,7 +20,6 @@
--run-libc-freeres=3Dno|yes free up glibc memory at exit? [yes]
--simulation-hints=3Dhint1,hint2,... known hints:
lax-ioctls, enable-outer [none]
- --pointercheck=3Dno|yes enforce client address space limits [yes=
]
--show-emwarns=3Dno|yes show warnings about emulation limits? [n=
o]
--smc-check=3Dnone|stack|all checks for self-modifying code: none,
only for code found in stacks, or all [sta=
ck]
Modified: trunk/none/tests/cmdline2.stdout.exp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/none/tests/cmdline2.stdout.exp 2005-10-20 01:09:57 UTC (rev 495=
5)
+++ trunk/none/tests/cmdline2.stdout.exp 2005-10-20 01:37:15 UTC (rev 495=
6)
@@ -20,7 +20,6 @@
--run-libc-freeres=3Dno|yes free up glibc memory at exit? [yes]
--simulation-hints=3Dhint1,hint2,... known hints:
lax-ioctls, enable-outer [none]
- --pointercheck=3Dno|yes enforce client address space limits [yes=
]
--show-emwarns=3Dno|yes show warnings about emulation limits? [n=
o]
--smc-check=3Dnone|stack|all checks for self-modifying code: none,
only for code found in stacks, or all [sta=
ck]
|