|
From: <sv...@va...> - 2005-08-28 05:21:19
|
Author: njn
Date: 2005-08-28 06:21:17 +0100 (Sun, 28 Aug 2005)
New Revision: 4548
Log:
Add some comments.
Modified:
trunk/addrcheck/ac_main.c
Modified: trunk/addrcheck/ac_main.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/addrcheck/ac_main.c 2005-08-28 05:10:48 UTC (rev 4547)
+++ trunk/addrcheck/ac_main.c 2005-08-28 05:21:17 UTC (rev 4548)
@@ -707,6 +707,7 @@
abits >>=3D (a & 4);
abits &=3D 15;
PROF_EVENT(66, "");
+ // XXX: Should this be "if (!is_distinguished_sm(sm) && abits =3D=3D =
VGM_NIBBLE_VALID)"?
if (abits =3D=3D VGM_NIBBLE_VALID) {
/* Handle common case quickly: a is suitably aligned, is mapped,
and is addressible. So just return. */
@@ -727,6 +728,7 @@
AcSecMap* sm =3D primary_map[sec_no];
UInt a_off =3D (SM_OFF(a)) >> 3;
PROF_EVENT(67, "");
+ // XXX: Should this be "if (!is_distinguished_sm(sm) && sm->abits[a_o=
ff] =3D=3D VGM_BYTE_VALID)"?
if (sm->abits[a_off] =3D=3D VGM_BYTE_VALID) {
/* Handle common case quickly. */
return;
@@ -746,6 +748,7 @@
AcSecMap* sm =3D primary_map[sec_no];
UInt a_off =3D (SM_OFF(a)) >> 3;
PROF_EVENT(68, "");
+ // XXX: Should this be "if (!is_distinguished_sm(sm) && sm->abits[a_o=
ff] =3D=3D VGM_BYTE_VALID)"?
if (sm->abits[a_off] =3D=3D VGM_BYTE_VALID) {
/* Handle common case quickly. */
return;
|