Re: [Valgrind-developers] Inotify system call wrapper

[John M. <tt...@te...>]

On Mon, 2005-07-25 at 16:10 +0100, Tom Hughes wrote:
> In message <yek...@de...>
>         Tom Hughes <to...@co...> wrote:
> 
> > In message <1122302613.2226.5.camel@localhost>
> >         John McCutchan <tt...@te...> wrote:
> >
> >> I've attached a patch that wraps the inotify system calls on x86 linux.
> >> Please consider this for the next version of valgrind.
> >
> > I can't see any sign of these calls in the 2.6.12 kernel source. Are
> > they part of the standard kernel?
> 
> I've found it in the 2.6.13-rc3 source now. I notice that it's only
> hooked in to the x86 system call table though.
> 

It will be hooked into amd64 soon to. Nothing about the code is platform
specific, but we are letting the platforms hook it up as they need.

> I've updated our lists of system call numbers, and I'm just fixing up
> a couple of things in your patch before committing it but I notice
> that you've marked inotify_init as a blocking call but it doesn't look
> like it should block. Can you clarify when it will block?

:), I really didn't know what I was doing, but sys_open, and sys_futex
(both which can create fd's like inotify_init) say they might block. So,
I was trying to be conservative and added that.

John McCutchan