|
From: <sv...@va...> - 2005-07-24 07:15:47
|
Author: sewardj
Date: 2005-07-24 08:15:44 +0100 (Sun, 24 Jul 2005)
New Revision: 4238
Log:
Get rid of --support-elan3=3D. This flag wasn't doing anything since
the Elan3 user-space driver now works on unmodified Valgrind.
Modified:
trunk/coregrind/m_main.c
trunk/coregrind/m_options.c
trunk/coregrind/m_syswrap/syswrap-x86-linux.c
trunk/coregrind/pub_core_options.h
trunk/none/tests/cmdline1.stdout.exp
trunk/none/tests/cmdline2.stdout.exp
Modified: trunk/coregrind/m_main.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_main.c 2005-07-24 07:00:45 UTC (rev 4237)
+++ trunk/coregrind/m_main.c 2005-07-24 07:15:44 UTC (rev 4238)
@@ -1268,7 +1268,6 @@
" --run-libc-freeres=3Dno|yes free up glibc memory at exit? [yes]\n"
" --weird-hacks=3Dhack1,hack2,... recognised hacks: lax-ioctls,ioctl=
-mmap [none]\n"
" --pointercheck=3Dno|yes enforce client address space limits [ye=
s]\n"
-" --support-elan3=3Dno|yes hacks for Quadrics Elan3 support [no]\n=
"
" --show-emwarns=3Dno|yes show warnings about emulation limits? [=
no]\n"
" --smc-check=3Dnone|stack|all checks for self-modifying code: none,=
\n"
" only for code found in stacks, or all [st=
ack]\n"
@@ -1481,7 +1480,6 @@
else VG_BOOL_CLO(arg, "--demangle", VG_(clo_demangle))
else VG_BOOL_CLO(arg, "--error-limit", VG_(clo_error_limit))
else VG_BOOL_CLO(arg, "--pointercheck", VG_(clo_pointercheck))
- else VG_BOOL_CLO(arg, "--support-elan3", VG_(clo_support_elan3)=
)
else VG_BOOL_CLO(arg, "--show-emwarns", VG_(clo_show_emwarns))
else VG_NUM_CLO (arg, "--max-stackframe", VG_(clo_max_stackframe=
))
else VG_BOOL_CLO(arg, "--profile", VG_(clo_profile))
Modified: trunk/coregrind/m_options.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_options.c 2005-07-24 07:00:45 UTC (rev 4237)
+++ trunk/coregrind/m_options.c 2005-07-24 07:15:44 UTC (rev 4238)
@@ -72,7 +72,6 @@
Bool VG_(clo_track_fds) =3D False;
Bool VG_(clo_show_below_main)=3D False;
Bool VG_(clo_pointercheck) =3D True;
-Bool VG_(clo_support_elan3) =3D False;
Bool VG_(clo_branchpred) =3D False;
Bool VG_(clo_model_pthreads) =3D False;
Bool VG_(clo_show_emwarns) =3D False;
Modified: trunk/coregrind/m_syswrap/syswrap-x86-linux.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_syswrap/syswrap-x86-linux.c 2005-07-24 07:00:45 UTC=
(rev 4237)
+++ trunk/coregrind/m_syswrap/syswrap-x86-linux.c 2005-07-24 07:15:44 UTC=
(rev 4238)
@@ -419,11 +419,11 @@
If the clone call specifies a NULL esp for the new thread, then
it actually gets a copy of the parent's esp.
*/
- /* HACK: The clone call done by the Quadrics Elan3 driver specifies
+ /* Note: the clone call done by the Quadrics Elan3 driver specifies
clone flags of 0xF00, and it seems to rely on the assumption
- that the child inherits a copy of the parent's GDT. Hence that
- is passed as an arg to setup_child. */
- setup_child( &ctst->arch, &ptst->arch, True /*VG_(clo_support_elan3)*=
/ );
+ that the child inherits a copy of the parent's GDT. =20
+ setup_child takes care of setting that up. */
+ setup_child( &ctst->arch, &ptst->arch, True );
=20
/* Make sys_clone appear to have returned Success(0) in the
child. */
@@ -1124,12 +1124,6 @@
VG_(message)(Vg_UserMsg, "");
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%x", ARG1);
VG_(message)(Vg_UserMsg, "");
- VG_(message)(Vg_UserMsg, "NOTE: if this happened when attempting "
- "to run code using");
- VG_(message)(Vg_UserMsg, " Quadrics Elan3 user-space drivers,=
"
- " you should re-run ");
- VG_(message)(Vg_UserMsg, " with --support-elan3=3Dyes.");
- VG_(message)(Vg_UserMsg, "");
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads o=
r NPTL)");
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfo=
rk");
Modified: trunk/coregrind/pub_core_options.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/pub_core_options.h 2005-07-24 07:00:45 UTC (rev 4237)
+++ trunk/coregrind/pub_core_options.h 2005-07-24 07:15:44 UTC (rev 4238)
@@ -145,9 +145,6 @@
/* Model the pthread library */
extern Bool VG_(clo_model_pthreads);
=20
-/* HACK: Use hacked version of clone for Quadrics Elan3 drivers */
-extern Bool VG_(clo_support_elan3);
-
/* Should we show VEX emulation warnings? Default: NO */
extern Bool VG_(clo_show_emwarns);
=20
Modified: trunk/none/tests/cmdline1.stdout.exp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/none/tests/cmdline1.stdout.exp 2005-07-24 07:00:45 UTC (rev 423=
7)
+++ trunk/none/tests/cmdline1.stdout.exp 2005-07-24 07:15:44 UTC (rev 423=
8)
@@ -15,7 +15,6 @@
--run-libc-freeres=3Dno|yes free up glibc memory at exit? [yes]
--weird-hacks=3Dhack1,hack2,... recognised hacks: lax-ioctls,ioctl-=
mmap [none]
--pointercheck=3Dno|yes enforce client address space limits [yes=
]
- --support-elan3=3Dno|yes hacks for Quadrics Elan3 support [no]
--show-emwarns=3Dno|yes show warnings about emulation limits? [n=
o]
--smc-check=3Dnone|stack|all checks for self-modifying code: none,
only for code found in stacks, or all [sta=
ck]
Modified: trunk/none/tests/cmdline2.stdout.exp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/none/tests/cmdline2.stdout.exp 2005-07-24 07:00:45 UTC (rev 423=
7)
+++ trunk/none/tests/cmdline2.stdout.exp 2005-07-24 07:15:44 UTC (rev 423=
8)
@@ -15,7 +15,6 @@
--run-libc-freeres=3Dno|yes free up glibc memory at exit? [yes]
--weird-hacks=3Dhack1,hack2,... recognised hacks: lax-ioctls,ioctl-=
mmap [none]
--pointercheck=3Dno|yes enforce client address space limits [yes=
]
- --support-elan3=3Dno|yes hacks for Quadrics Elan3 support [no]
--show-emwarns=3Dno|yes show warnings about emulation limits? [n=
o]
--smc-check=3Dnone|stack|all checks for self-modifying code: none,
only for code found in stacks, or all [sta=
ck]
|