|
From: Nicholas N. <nj...@cs...> - 2005-07-22 14:04:37
|
On Fri, 22 Jul 2005, Tom Hughes wrote: > Does anybody know why there are explicit prototypes for printf and > exit in valgrind.h on amd64? > > According to subversion Nick put them in as part of revision 3120 but > that was an ARM commit which seems a bit odd... > > The reason I ask is that it seems a bit dodgy and it caused a problem > when I was building RPMs yesterday and I wound up patching them out > and everything still seems to work. Oh, that's a legacy from when the asm wasn't implemented and VALGRIND_MAGIC_SEQUENCE printed a message and called exit. I should have put a "temporary" comment on them. I've removed them. Thanks. N |