|
From: Julian S. <js...@ac...> - 2005-06-28 13:16:01
|
> >> Don't mark segments as SF_FIXED when VKI_MAP_FIXED isn't specified. > > > > What problem does this solve? > > Are you just curious or do you see breakage? Really just curious. It seems to make no difference to regtests here; however the mmap stuff is fragile and so I wondered if you'd fallen over some bug to which this was the solution. Ah, I guess you've been looking at this because you were looking at Segments and SegInfos, yes? > Segments are meant to be marked as SF_FIXED when they are mapped in with > VKI_MAP_FIXED. Because of the above bug, all segments were being marked > as SF_FIXED. I'm not aware of any problems this caused, but it didn't > seem like a good idea to be mis-marking our segments. It could be a bug I introduced when messing with those wrappers some time back. > I'd be happy to get rid of this SF_FIXED flag altogether. It's never used > in a meaningful way (not surprising, given that it was being consistently > misapplied). A number of the SF_* flags fall into this category. GC on, dude .. J |