|
From: <sv...@va...> - 2005-06-25 19:34:20
|
Author: njn
Date: 2005-06-25 20:33:50 +0100 (Sat, 25 Jun 2005)
New Revision: 4019
Log:
Remove the Segment back-pointer from SegInfo. The only place it was
being used was in resolve_redir(), and due to the way resolve_redir()
is called, the involved test was always failing anyway. So we lose
nothing by removing it except some complexity -- there is no longer a
circularity between Segments and SegInfos.
Modified:
trunk/coregrind/m_debuginfo/priv_symtab.h
trunk/coregrind/m_debuginfo/symtab.c
trunk/coregrind/m_redir.c
Modified: trunk/coregrind/m_debuginfo/priv_symtab.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_debuginfo/priv_symtab.h 2005-06-25 15:22:10 UTC (re=
v 4018)
+++ trunk/coregrind/m_debuginfo/priv_symtab.h 2005-06-25 19:33:50 UTC (re=
v 4019)
@@ -171,7 +171,6 @@
struct _SegInfo {
struct _SegInfo* next; /* list of SegInfos */
=20
- Segment *seg; /* first segment we're mapped out of */
Int ref;
=20
/* Description of the mapped segment. */
Modified: trunk/coregrind/m_debuginfo/symtab.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_debuginfo/symtab.c 2005-06-25 15:22:10 UTC (rev 401=
8)
+++ trunk/coregrind/m_debuginfo/symtab.c 2005-06-25 19:33:50 UTC (rev 401=
9)
@@ -1648,8 +1648,6 @@
si->cfisi_size =3D si->cfisi_used =3D 0;
si->cfisi_minaddr =3D si->cfisi_maxaddr =3D 0;
=20
- si->seg =3D seg;
-
si->stab_typetab =3D NULL;
=20
si->plt_start =3D si->plt_size =3D 0;
Modified: trunk/coregrind/m_redir.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_redir.c 2005-06-25 15:22:10 UTC (rev 4018)
+++ trunk/coregrind/m_redir.c 2005-06-25 19:33:50 UTC (rev 4019)
@@ -210,12 +210,7 @@
Bool resolved;
=20
vg_assert(si !=3D NULL);
- vg_assert(si->seg !=3D NULL);
=20
- /* no redirection from Valgrind segments */
- if (si->seg->flags & SF_VALGRIND)
- return False;
-
resolved =3D from_resolved(redir);
vg_assert(!resolved);
vg_assert(redir->from_sym !=3D NULL);
|