|
From: <sv...@va...> - 2005-06-20 18:14:41
|
Author: sewardj
Date: 2005-06-20 19:14:27 +0100 (Mon, 20 Jun 2005)
New Revision: 3971
Log:
Although it doesn't actually matter from a generated-code point of
view, it doesn't make much sense for the args to
VG_(mk_SysRes_{x86,amd64}_linux) to be stated as unsigned; therefore
make them signed.
Modified:
trunk/coregrind/m_syscall.c
trunk/coregrind/pub_core_syscall.h
Modified: trunk/coregrind/m_syscall.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_syscall.c 2005-06-20 18:03:17 UTC (rev 3970)
+++ trunk/coregrind/m_syscall.c 2005-06-20 18:14:27 UTC (rev 3971)
@@ -54,7 +54,7 @@
syscall returns a value in -1 .. -4095 as a valid result so we can
safely test with -4095.
*/
-SysRes VG_(mk_SysRes_x86_linux) ( UWord val ) {
+SysRes VG_(mk_SysRes_x86_linux) ( Word val ) {
SysRes res;
res.isError =3D val >=3D -4095 && val <=3D -1;
res.val =3D res.isError ? -val : val;
@@ -62,15 +62,14 @@
}
=20
/* Similarly .. */
-SysRes VG_(mk_SysRes_amd64_linux) ( UWord val ) {
+SysRes VG_(mk_SysRes_amd64_linux) ( Word val ) {
SysRes res;
res.isError =3D val >=3D -4095 && val <=3D -1;
res.val =3D res.isError ? -val : val;
return res;
}
=20
-/* PPC uses the CR7.SO bit to flag an error (CR0 in IBM-speke)
- */
+/* PPC uses the CR7.SO bit to flag an error (CR0 in IBM-speke) */
SysRes VG_(mk_SysRes_ppc32_linux) ( UInt val, UInt errflag ) {
SysRes res;
res.isError =3D errflag !=3D 0;
Modified: trunk/coregrind/pub_core_syscall.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/pub_core_syscall.h 2005-06-20 18:03:17 UTC (rev 3970)
+++ trunk/coregrind/pub_core_syscall.h 2005-06-20 18:14:27 UTC (rev 3971)
@@ -61,8 +61,8 @@
#define vgPlain_do_syscall6(s,a,b,c,d,e,f) VG_(do_syscall)((s),(a),(b),\
(c),(d),(e),(=
f))
=20
-extern SysRes VG_(mk_SysRes_x86_linux) ( UWord val );
-extern SysRes VG_(mk_SysRes_amd64_linux) ( UWord val );
+extern SysRes VG_(mk_SysRes_x86_linux) ( Word val );
+extern SysRes VG_(mk_SysRes_amd64_linux) ( Word val );
extern SysRes VG_(mk_SysRes_ppc32_linux) ( UInt val, UInt errflag );
extern SysRes VG_(mk_SysRes_Error) ( UWord val );
extern SysRes VG_(mk_SysRes_Success) ( UWord val );
|