|
From: Nicholas N. <nj...@cs...> - 2005-06-20 13:18:07
|
On Mon, 20 Jun 2005, Paul Mackerras wrote: >> On a platform where it fails (RH73) the default script has this >> >> . = 0x08048000 + SIZEOF_HEADERS; >> >> and it is unchanged in the post-sed-ified result. >> >> I must say I'm not convinced by this change. It seems overly >> fragile. How it was before, the entry address (0x8048000 / whatever) >> would be changed to 'kickstart_base' regardless of the surrounding >> context, which sounds like the Right Thing To Do; whereas now we're >> context dependent. > > The idea was to remove the dependence on the specific 0x8048000 > value. Does the RH73 default script have any other hex numbers in it > before the 0x08048000? How about we just modify the first line that > has a hex number in it? Sounds ok to me. I tried to this but my sed-fu is too weak; I kept changing every hex value in the file which is no good. Another option is to set a constant BASE_LOAD_ADDR for each platform in configure.in, and use @BASE_LOAD_ADDR@ in the sed expression. But, as Paul says, why use an extra constant if you don't need to? N |