|
From: <sv...@va...> - 2005-06-20 03:37:31
|
Author: njn
Date: 2005-06-20 04:36:51 +0100 (Mon, 20 Jun 2005)
New Revision: 3966
Log:
Remove some unnecessary #includes, comment some others.
Modified:
trunk/coregrind/m_errormgr.c
trunk/coregrind/m_execontext.c
trunk/coregrind/m_libcassert.c
trunk/coregrind/m_libcfile.c
trunk/coregrind/m_libcmman.c
trunk/coregrind/m_libcprint.c
trunk/coregrind/m_redir.c
trunk/coregrind/m_signals.c
trunk/coregrind/m_stacktrace.c
trunk/coregrind/m_translate.c
trunk/coregrind/m_transtab.c
trunk/coregrind/vg_preloaded.c
Modified: trunk/coregrind/m_errormgr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_errormgr.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_errormgr.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -29,7 +29,7 @@
*/
=20
#include "pub_core_basics.h"
-#include "pub_core_threadstate.h"
+#include "pub_core_threadstate.h" // For VG_N_THREADS
#include "pub_core_debugger.h"
#include "pub_core_debuginfo.h"
#include "pub_core_errormgr.h"
@@ -38,12 +38,11 @@
#include "pub_core_libcassert.h"
#include "pub_core_libcfile.h"
#include "pub_core_libcprint.h"
-#include "pub_core_libcproc.h"
+#include "pub_core_libcproc.h" // For VG_(getpid)()
#include "pub_core_mallocfree.h"
#include "pub_core_options.h"
-#include "pub_core_stacktrace.h"
#include "pub_core_tooliface.h"
-#include "pub_core_translate.h"
+#include "pub_core_translate.h" // for VG_(translate)()
=20
/*------------------------------------------------------------*/
/*--- Globals ---*/
Modified: trunk/coregrind/m_execontext.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_execontext.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_execontext.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -31,7 +31,7 @@
#include "pub_core_basics.h"
#include "pub_core_execontext.h"
#include "pub_core_libcassert.h"
-#include "pub_core_libcprint.h"
+#include "pub_core_libcprint.h" // For VG_(message)()
#include "pub_core_mallocfree.h"
#include "pub_core_options.h"
#include "pub_core_profile.h"
Modified: trunk/coregrind/m_libcassert.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_libcassert.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_libcassert.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -33,11 +33,11 @@
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
#include "pub_core_libcprint.h"
-#include "pub_core_libcproc.h"
+#include "pub_core_libcproc.h" // For VG_(gettid)()
#include "pub_core_options.h"
#include "pub_core_stacktrace.h"
#include "pub_core_syscall.h"
-#include "pub_core_tooliface.h"
+#include "pub_core_tooliface.h" // For VG_(details)
#include "vki_unistd.h"
=20
/* ---------------------------------------------------------------------
Modified: trunk/coregrind/m_libcfile.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_libcfile.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_libcfile.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -34,7 +34,6 @@
#include "pub_core_libcfile.h"
#include "pub_core_libcprint.h"
#include "pub_core_mallocfree.h"
-#include "pub_core_options.h"
#include "pub_core_syscall.h"
#include "vki_unistd.h"
=20
Modified: trunk/coregrind/m_libcmman.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_libcmman.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_libcmman.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -34,7 +34,6 @@
#include "pub_core_libcassert.h"
#include "pub_core_libcmman.h"
#include "pub_core_libcprint.h"
-#include "pub_core_libcproc.h"
#include "pub_core_syscall.h"
#include "vki_unistd.h"
=20
Modified: trunk/coregrind/m_libcprint.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_libcprint.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_libcprint.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -32,11 +32,11 @@
#include "pub_core_debuglog.h"
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
-#include "pub_core_libcfile.h"
+#include "pub_core_libcfile.h" // For VG_(write)(), VG_(write_socket)(=
)
#include "pub_core_libcprint.h"
-#include "pub_core_libcproc.h"
+#include "pub_core_libcproc.h" // For VG_(getpid)()
#include "pub_core_options.h"
-#include "valgrind.h" // for RUNNING_ON_VALGRIND
+#include "valgrind.h" // For RUNNING_ON_VALGRIND
=20
#include <time.h>
#include <sys/time.h>
Modified: trunk/coregrind/m_redir.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_redir.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_redir.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -31,7 +31,7 @@
*/
=20
#include "pub_core_basics.h"
-#include "pub_core_aspacemgr.h"
+#include "pub_core_aspacemgr.h" // Needed for pub_core_redir.h
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
#include "pub_core_libcprint.h"
@@ -41,7 +41,7 @@
#include "pub_core_skiplist.h"
#include "pub_core_trampoline.h"
#include "pub_core_transtab.h"
-#include "m_debuginfo/priv_symtab.h" // XXX: bad!
+#include "m_debuginfo/priv_symtab.h" // XXX: bad! For SegInfo internal=
s
=20
/*------------------------------------------------------------*/
/*--- General purpose redirection. ---*/
Modified: trunk/coregrind/m_signals.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_signals.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_signals.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -95,8 +95,8 @@
#include "pub_core_options.h"
#include "pub_core_scheduler.h"
#include "pub_core_signals.h"
-#include "pub_core_sigframe.h"
-#include "pub_core_stacktrace.h"
+#include "pub_core_sigframe.h" // For VG_(sigframe_create)()
+#include "pub_core_stacktrace.h" // For VG_(get_and_pp_StackTrace)()
#include "pub_core_syscall.h"
#include "pub_core_syswrap.h"
#include "pub_core_tooliface.h"
Modified: trunk/coregrind/m_stacktrace.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_stacktrace.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_stacktrace.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -30,8 +30,7 @@
=20
#include "pub_core_basics.h"
#include "pub_core_threadstate.h"
-#include "pub_core_aspacemgr.h"
-#include "pub_core_debuginfo.h"
+#include "pub_core_aspacemgr.h" // For VG_(is_addressable)()
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
#include "pub_core_libcprint.h"
@@ -267,5 +266,5 @@
=20
=20
/*--------------------------------------------------------------------*/
-/*--- end m_stacktrace.c ---*/
+/*--- end ---*/
/*--------------------------------------------------------------------*/
Modified: trunk/coregrind/m_translate.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_translate.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_translate.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -37,9 +37,9 @@
#include "pub_core_libcprint.h"
#include "pub_core_options.h"
#include "pub_core_profile.h"
-#include "pub_core_redir.h"
-#include "pub_core_signals.h"
-#include "pub_core_tooliface.h"
+#include "pub_core_redir.h" // For VG_(code_redirect)()
+#include "pub_core_signals.h" // For VG_(synth_fault_{perms,mappin=
g})()
+#include "pub_core_tooliface.h" // For VG_(tdict)
#include "pub_core_translate.h"
#include "pub_core_transtab.h"
=20
Modified: trunk/coregrind/m_transtab.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_transtab.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/m_transtab.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -30,15 +30,15 @@
*/
=20
#include "pub_core_basics.h"
-#include "pub_core_debuginfo.h"
+#include "pub_core_debuginfo.h" // For VG_(get_fnname_w_offset)()
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
-#include "pub_core_libcmman.h"
+#include "pub_core_libcmman.h" // For VG_(get_memory_from_mmap)()
#include "pub_core_libcprint.h"
#include "pub_core_options.h"
-#include "pub_core_tooliface.h"
+#include "pub_core_tooliface.h" // For VG_(details).avg_translation_=
sizeB
// XXX: this module should not depend on m_translate!
-#include "pub_core_translate.h"
+#include "pub_core_translate.h" // For VG_(translate)()
#include "pub_core_transtab.h"
=20
/* #define DEBUG_TRANSTAB */
Modified: trunk/coregrind/vg_preloaded.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/vg_preloaded.c 2005-06-20 02:23:07 UTC (rev 3965)
+++ trunk/coregrind/vg_preloaded.c 2005-06-20 03:36:51 UTC (rev 3966)
@@ -46,8 +46,8 @@
#include "coregrind.h"
=20
#include "pub_core_basics.h"
-#include "pub_core_debuginfo.h" // needed for pub_core_redir.h :(
-#include "pub_core_redir.h"
+#include "pub_core_debuginfo.h" // Needed for pub_core_redir.h
+#include "pub_core_redir.h" // For VG_NOTIFY_ON_LOAD
=20
/* ---------------------------------------------------------------------
Hook for running __libc_freeres once the program exits.
|