Re: [Valgrind-users] linux-powerpc syscall settimeofday commented out

[Pim N. <pn...@ai...>]

Nicholas Nethercote wrote:
> On Mon, 27 Nov 2006, Pim Nijdam wrote:
> 
>> For the linux powerpc the syscall settimeofday (79) is commented out.
>> Does someone has any idea why? I guess it just was never tested.
> 
> 
> Probably.
> 
>> I decommented it and it seems to work fine, however I didn't sincerely
>> test it. If it is still commented out just because it wasn't tested I'm
>> willing to test it. Is there a testcase available?
>>
>> If there's another reason, please point it out. I need this to work so
>> I'm willing to spend some time on it.
> 
> 
> No test case, please test it thoroughly and let us know if it works well 
> in which case we can commit the change!

I tested it and it works well.

However, PRE(sys_settimeofday) only checks if the second argument is 
NULL, but according to the Linux manual page of settimeofday both 
arguments can be NULL. Adding a check and Valgrind reported as expected. 
  Unfortunetly I don't know if this specification of settimeofday is 
generic or Linux specific.

Pim Nijdam

-- 
This message has been scanned for viruses and is believed to be clean