|
From: Julian S. <js...@ac...> - 2006-10-05 18:04:06
|
Committed, including your documentation stuff (r6196 and 6197). Thanks for that. At some point (no hurry) it would be good if you could confirm that a clean checkout of the trunk now works as you intend viz-a-viz mozilla's memory pools. J On Thursday 05 October 2006 18:45, Graydon Hoare wrote: > Julian Seward wrote: > > Looks fine. The only problem I can see is that you #included > > coregrind/pub_core_options.h into memcheck/mc_malloc_wrappers.c, > > which totally breaks the core/tool abstraction :-) Tools are > > only allowed to include pub_tool_*.h. > > > > But AFAICS it's only to provide debugging printing (for the mempools > > machinery itself) at -v -v and above. So how about if I just hardwire > > a fixed backtrace depth, say 16, in place of those uses of > > VG_(clo_backtrace_size) ? > > Sure. I was just trying to conform to house style; whatever works for you. > > -graydon |