Re: [Valgrind-users] Problems with make install

[Neil Y. <Nei...@wi...>]

I've now hacked this into submission by replacing the shell conditionals =
with Makefile conditionals, e.g.
=20
neily valgrind-3.2.1 14:15:10 1014 > diff memcheck/Makefile.~1~ =
memcheck/Makefile
1206c1206
<       if [ -n "$(noinst_PROGRAMS)" ] ; then \
---
> ifneq ("$(noinst_PROGRAMS)", "")
1212,1214c1212,1214
<         done ; \
<       fi ; \
<       if [ -n "$(noinst_LIBRARIES)" ] ; then \
---
>         done ;
> endif
> ifneq ("$(noinst_LIBRARIES)", "")
1222,1223c1222,1223
<         done ; \
<       fi
---
>         done ;
> endif
neily valgrind-3.2.1 14:15:43 1015 >=20

I had to do this for:
cachegrind/Makefile
callgrind/Makefile
coregrind/Makefile
helgrind/Makefile
lackey/Makefile
massif/Makefile
memcheck/Makefile
none/Makefile

Neil Youngman


-----Original Message-----
From: val...@li... on behalf of Neil =
Youngman
Sent: Wed 27-Sep-06 16:19
To: val...@li...
Subject: [Valgrind-users] Problems with make install
=20
I'm trying to install valgrind 3.2.1 on an old RedHat box (2.1AS) and it =
won't install. The error I see is=20

/bin/sh: -c: line 1: syntax error near unexpected token `;'

I've tracked this down to a section that comes out of various makefiles =
in subdirectories looking like " for f in ; do".

in the original Makefiles (it happens in most of them), it starts out =
looking like this

        if [ -n "$(noinst_PROGRAMS)" ] ; then \
          for f in $(noinst_PROGRAMS); do \

AIUI if $(noinst_PROGRAMS) is blank it's passed to the shell as=20

        if [ -n "" ] ; then \
          for f in ; do \

which BASH 2.0.5 won't accept.

I think I understand the problem, but I'm not sure how to fix it.

Neil Youngman