|
From: Nicholas N. <nj...@cs...> - 2005-03-16 02:36:55
|
On Sun, 13 Mar 2005, Nicholas Nethercote wrote:
> vg_symtab2.c: In function 'canonicaliseLoctab':
> vg_symtab2.c:691: warning: large integer implicitly truncated to unsigned
> type
> [...]
> I think the problem is that the 'size' field of the RiLoc struct is only a
> 12-bit integer. So I think the relevant part of the code above should be
> changed to this:
>
> if (new_size > MAX_LOC_SIZE) {
> si->loctab[i].size = MAX_LOC_SIZE;
> } else {
> si->loctab[i].size = (UShort)new_size;
> }
>
> Can someone confirm this is the right thing to do here? Thanks.
Since no-one complained, I'm going to commit this.
N
|