|
From: Jeremy F. <je...@go...> - 2005-02-27 01:35:59
|
Dirk Mueller wrote:
>CVS commit by mueller:
>
>these are used as function pointers, can't use regparms here, as gcc
>tries to tell you:
>
>mc_main.c:1968: warning: passing arg 1 of `vgPlain_init_new_mem_stack_4' from incompatible pointer type
>
>
Ah, no, surely the fix is to change the type of the pointer to include
the regparm? [ I see you reverted it. ]
I wish you'd given us a heads-up before checking all this stuff. It's
causing masses of conflicts with my pending changes, and it will just
make the Vex merge even more of a pain; it would be better to hold off
this cosmetic stuff until after the merge. Also, someone (Nick?) went
through and converted a lot of the comments to C99/C++ not long ago;
what's the motive behind converting them all back? gcc has always
supported them, no?
J
|