|
From: Nicholas N. <nj...@cs...> - 2005-02-24 02:05:35
|
On Wed, 23 Feb 2005, Jeremy Fitzhardinge wrote: > Nicholas Nethercote wrote: > >> Sounds good in principle. How complex is it, how much code has been >> added? > > Very little. It isn't much more complex than the original checker. > Patch attached; there's about 20 lines more code. This doesn't have the > full clique-grouping algorithm, which will add a bit more code (probably > <100 lines though). Seems reasonable, except that you've put lots of the code into the core. The leak checker is currently entirely within Memcheck (Addrcheck shares some of that code), and I think this distinction should be maintained. So eg. the code added in coregrind/x86/state.c should instead be in memcheck/x86/<something.c> (which currently doesn't exist). Or you could add an arch-specific function that returns some kind of GP register list, which would save you from having arch-specific code in Memcheck. N |