|
From: Tom H. <to...@co...> - 2005-02-10 13:06:01
|
In message <200...@ka...>
Greg Parker <gp...@us...> wrote:
> * Linux's auxv processing has been moved to VGOS_(build_client_stack_suffix).
> Other systems would define appropriate versions of that function
> and several others for prefix and suffix processing, and all of these
> OS-specific functions would be moved to other files.
What's VGOS_() about? Your patch doesn't seem to define it.
I assume it is for OS specific code, which is what VGA_() is for. Such
code should also go in the appropriate directory (coregrind/linux for
linux code).
What slight issue is that auxv is probably ELF specific rather than
linux specific, at least in general. Some auxv entries may be linux
specific.
> * `int argc` is mishandled wrong on 64-bit platforms. Mac OS X writes a
> four-byte argc followed by a four-byte zero pad. I don't know what
> Linux does. This version is probably incorrect regardless.
Well int is 4 bytes on 64 bit linux platforms, or at least on x86-64, so
it shouldn't need any padding. Is it 64 bits on the Mac?
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|