|
From: Tom H. <th...@cy...> - 2005-01-17 10:37:45
|
In message <41E...@bn...>
Sev Binello <se...@bn...> wrote:
> A while back I posted the message below indicating that Valgrind
> was not producing the
> full path for source code built with gcc 3.2.3
> I took a look at the code and found that vg_dwarf.c expected gcc
> to include the path in the file name,
> if it was using dwarf2 debug format.
> Therefor, it never bothered to look for the path in the directory
> table for files in dwarf2 format.
> It doesn't look like that assumption is correct.
> I modified the code in vg_dwarf.c to parse the directory table,
> and concatenate the path name to the file name.
> I've attached a patch file. It does not handle relative paths.
You have approached the problem from the wrong direction - valgrind
was never supposed to print the full path. It was an accident that
old gcc's put the full path in like that - other debug formats only
print the leafname.
There was a long discussion about this before when somebody wanted
the full path and consensus seemed to be against it except perhaps
as an option.
Patches are best filed in the bug tracker anyway - they are less
likely to get lost/forgotten that way.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|