Re: [Valgrind-developers] valgrind

[Nicholas N. <nj...@ca...>]

On Fri, 12 Nov 2004, Tom Hughes wrote:

>> +// XXX: prototype here seemingly doesn't match the prototype for i386-linux,
>> +// but it seems to work nonetheless...
>
> It looks like it matches the prototype to me... Are you talking about
> the fourth argument to do_execve that sys_execve passes? That is just
> a pointer to the raw register set passed to the system call.

The prototype for sys_exec(), which gets called from the sys_call_table 
indirection, is this:

   asmlinkage int sys_execve(struct pt_regs regs)

on x86.  This is different to most of the others which have the args done 
as normal.  I'm not sure how these 'pt_regs' ones work.

> BTW the scalar test is no longer building on my RH9 box because at
> least one of the system call numbers is not in asm/unistd.h on that
> machine. Well actually it is, but is commented out (lookup_dcookie).
>
> I guess we either need to ifdef tests of system calls that might not
> exist or we need to use out own list of system call numbers.

Yep.  I'll use our own list.

Thanks.

N