|
From: Nicholas N. <nj...@ca...> - 2004-10-14 10:26:08
|
On Wed, 13 Oct 2004, Josef Weidendorfer wrote:
>>> -Cflags: -I${includedir}
>>> +Cflags: -I${includedir} -I${includedir}/@VG_ARCH@
>>
>> So that's the only change I need to put into Valgrind to make you happy?
>> If so, that's no problem.
>
> Thanks.
Done (and @VG_PLATFORM@ too).
> Further wishes: -)
> In Cachegrind, you added a x86 subdirectory for the CPUID stuff. I think it
> would be good to move this to Valgrind itself and add a general function to
> the tool API for requesting architecture features like cache sizes.
>
> typedef enum { Vg_CacheI1Size, Vg_CacheI1Assoc,
> VG_CacheI1LineSize, ... } VgArchFeature;
> extern int VG_(get_arch_feature)(VgArchFeature, char* resultBuffer, int len);
The difficulty here is that CPUID has so many different parts that it's
not obvious what the interface for querying it would look like.
N
|