Re: [Valgrind-developers] Valgrind headers for external skins

[Tom H. <th...@cy...>]

In message <200...@gm...>
          Josef Weidendorfer <Jos...@gm...> wrote:

> In Cachegrind, you added a x86 subdirectory for the CPUID stuff. I think it
> would be good to move this to Valgrind itself and add a general function to
> the tool API for requesting architecture features like cache sizes.
> 
> typedef enum { Vg_CacheI1Size, Vg_CacheI1Assoc,
> 	 VG_CacheI1LineSize, ... } VgArchFeature;
> extern int VG_(get_arch_feature)(VgArchFeature, char* resultBuffer, int len);

I have to say that I'm not a huge fan of an interface as loosely
typed as that...

> And regarding arch-abstraction, it would be cool to get rid of the
> arch-specifics in tools whenever possible: E.g. in cachegrind (and calltree
> also), there is the MMX/SSE stuff. Perhaps some functions could be added
> providing additional high level properties for UOps like if it is accessing
> memory and so on. Prove of concept would be a cachegrind with same source for
> PowerPC, x86 and x86_64.

I think that sort of thing comes under the heading of reworking UCode
for better platform independence which I believe Julian is working on?

Tom

-- 
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/