|
From: Nicholas N. <nj...@ca...> - 2004-07-28 08:36:08
|
On Mon, 26 Jul 2004, Jeremy Fitzhardinge wrote: >> The attached diff removes the redundant as_pad() in vg_main.c, which >> allows layout_client_space() to merge with layout_remaining_space. It >> works fine on my machine. Does it seem ok to you? I'll commit if so. > > That seems OK, but I think I put the second as_pad there deliberately, > even though its redundant. Mainly, I think, to reduce the number of > implicit dependencies between stage1 and stage2. The as_pad in stage1 > is functionally there to make sure that stage2 loads in the right place; > the one in stage2 is to make sure the tools load in the right place. > > Hm, it isn't a very strong reason for keeping it there. Especially since stage2 aborts if stage1 didn't launch it. And there doesn't seem to be any use in allowing the possibility of stage2 being launched on its own? N |