From: Pete Z. <za...@re...> - 2004-03-01 03:31:33
|
Hi, I was looking at the way timer works on UML and noticed that missed_ticks is not actually used for anything. Is there a plan for it? If not, maybe we should drop it. Cheers, -- Pete diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/skas/trap_user.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/skas/trap_user.c --- linux-2.6.3-rc2-uml-1/arch/um/kernel/skas/trap_user.c 2004-02-15 21:26:30.000000000 -0800 +++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/skas/trap_user.c 2004-02-29 18:48:11.000000000 -0800 @@ -35,8 +35,6 @@ errno = save_errno; } -extern int missed_ticks[]; - void user_signal(int sig, union uml_pt_regs *regs) { struct signal_info *info; diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/time_kern.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/time_kern.c --- linux-2.6.3-rc2-uml-1/arch/um/kernel/time_kern.c 2004-02-15 21:26:31.000000000 -0800 +++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/time_kern.c 2004-02-29 19:02:44.000000000 -0800 @@ -41,12 +41,6 @@ /* Changed at early boot */ int timer_irq_inited = 0; -/* missed_ticks will be modified after kernel memory has been - * write-protected, so this puts it in a section which will be left - * write-enabled. - */ -int __attribute__ ((__section__ (".unprotected"))) missed_ticks[NR_CPUS]; - static int first_tick; static unsigned long long prev_tsc; static long long delta; /* Deviation per interval */ diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/trap_user.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/trap_user.c --- linux-2.6.3-rc2-uml-1/arch/um/kernel/trap_user.c 2004-02-15 21:26:31.000000000 -0800 +++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/trap_user.c 2004-02-29 19:02:28.000000000 -0800 @@ -102,12 +102,11 @@ sig, &sc); } -extern int timer_irq_inited, missed_ticks[]; +extern int timer_irq_inited; void alarm_handler(int sig, struct sigcontext sc) { if(!timer_irq_inited) return; - missed_ticks[cpu()]++; if(sig == SIGALRM) switch_timers(0); |
From: Jeff D. <jd...@ad...> - 2004-03-01 04:15:14
|
On Sun, Feb 29, 2004 at 07:19:32PM -0800, Pete Zaitcev wrote: > I was looking at the way timer works on UML and noticed that missed_ticks > is not actually used for anything. Is there a plan for it? If not, maybe > we should drop it. Thanks, I just hadn't got around to cleaning that up. Jeff |
From: Jeff D. <jd...@ad...> - 2004-03-11 21:39:10
|
On Sun, Feb 29, 2004 at 07:19:32PM -0800, Pete Zaitcev wrote: > I was looking at the way timer works on UML and noticed that missed_ticks > is not actually used for anything. Is there a plan for it? If not, maybe > we should drop it. Applied, thanks. Jeff |