#5 Misc minor fixes and cleanups

closed
nobody
None
5
2004-09-24
2004-08-16
No

Attached patches fixes a few minor issues and cleans up
a few things.
- remove the static verbose variable -- it isn't used
anymore.
- Adjust the internal memory layout and corrected the
comments.
With compression enabled it's now:
UR: 0x0E200-0x3FFFF
FDL: 0x00000-0x0E1ff
VDW: 0x0E200-0x3FFFF
I think that's what the original author intended,
- Allocate the scratch buffer and the decompression
intra-frame buffer with vmalloc instead of kmalloc.
Allocation of such large buffers with is more likely to
fail (due to memory fragmentation).

Discussion

  • Dwaine Garden

    Dwaine Garden - 2004-08-16

    Logged In: YES
    user_id=607772

    There are no files that are attached to this patch. Could
    you please attach the files. I'll check it out and then submit
    it to CVS.

     
  • Dwaine Garden

    Dwaine Garden - 2004-08-25

    Logged In: YES
    user_id=607772

    It would seem that changing some of the memory stuff causes
    the video to be more unstable.

    Actually the picture with the random interference and your
    patches, cause the picture to be unwatchable.

    What's your situation like?

     
  • David Vrabel

    David Vrabel - 2004-08-25

    Logged In: YES
    user_id=36369

    Hmmm. Obviously, it's fine for me though I didn't do
    extensive testing -- mostly single frame grabs and low frame
    rates (5 fps) (and on a headless ARM system too) . Can I
    suggest you apply the patch in chunks and see which one
    causes the problem? e.g., kmalloc -> vmalloc should be
    harmless. If it's the internal memory layout changes that
    cause the problem then there's a chance I stuffed it up --
    it's damned confusing with all the bits all over the place,
    and of course, I could have misunderstood the chip datasheet.

     
  • Nobody/Anonymous

    Logged In: NO

    Ok..... Tested out just the kmalloc-> vmalloc and it looks
    good. It even looks like theres interference of those
    infamous white lines.

    I'll patch cvs with these changes, the memory layout will
    have to stay the same though.

    Thanks for helping in testing....

    Dwaine.

     
  • Dwaine Garden

    Dwaine Garden - 2004-09-09

    Logged In: YES
    user_id=607772

    I submitted the kmalloc -> vmalloc changes into cvs for
    people to test it out.

    Did you have time to confirm the memory layout changes?

    I'm testing it out too....

    Dwaine.

     
  • David Vrabel

    David Vrabel - 2004-09-13

    Logged In: YES
    user_id=36369

    Sorry, I've moved onto other projects and can no longer do
    any testing.

     
  • Dwaine Garden

    Dwaine Garden - 2004-09-24
    • status: open --> closed
     

Log in to post a comment.