From: Francesco M. <f18...@ya...> - 2008-11-20 20:53:47
|
Hi, using the upp_wx program I've thought to the following changes/improvements... let me know what you think of them. 1) the toolbar currently uses two radio boxes to inform the user about what hardware has been detected. This is a misuse of the checkbox widget; in fact in upp_wx they aren't used for user input just as "read-only" displays, isn't it? I think it would be better to create a wxControl-derived custom control, which simply draws: DETECTED HARDWARE: UPP v. 1.1 or DETECTED HARDWARE: UPP BOOTLOADER v. 1.1 it would be much more user-friendly, I believe. 2) the toolbar uses a wxComboBox. However there's no reason for the user to type inside it; why not use a wxChoice instead? 3) the main window currently displays 3 big grids. I'd suggest using instead a wxNotebook with 3 tabs: code, config, data. In this way it would be easier for the user to locate what he wants to view. Also, in future the "config" tab could contain a more complex UI layout to show the various config flag names, etc etc. Other possible notebook tabs to add are those displayed by piklab when selecting a specific device: - Device information: basic features of the selected PIC + link to microchip.com - Memory Map - Voltage-frequency Graphs - Pin diagrams, possibly with the PGD, PGC, Vdd, MCLR, GND pins highlighted. 4) currently when issuing a command which provokes a read/write operation on the USB, the program "hangs"; the UI doesn't redraw and the program does not respond to user. This is because those operations should be done in a secondary thread... this shouldn't be difficult to do; a simple wxThread should be enough. I'm ready to help with any of these tasks... Bye, Francesco -- |
From: Frans S. <fra...@gm...> - 2008-11-21 07:43:10
|
Hi Francesco, > Hi, > using the upp_wx program I've thought to the following > changes/improvements... let me know what you think of them. > > 1) the toolbar currently uses two radio boxes to inform the user about what > hardware has been detected. This is a misuse of the checkbox widget; in fact in > upp_wx they aren't used for user input just as "read-only" displays, isn't it? > You can actually click those radio boxes, if you have used the bootloader and then want to switch to usbpicprog mode, you can use them. Also in the rare case when you have an usbpicprog and a bootloader connected, you can choose one of them. > 2) the toolbar uses a wxComboBox. However there's no reason for the user to type > inside it; why not use a wxChoice instead? > Right! > 3) the main window currently displays 3 big grids. > I'd suggest using instead a wxNotebook with 3 tabs: code, config, data. > In this way it would be easier for the user to locate what he wants to view. > Also, in future the "config" tab could contain a more complex UI layout to show > the various config flag names, etc etc. > Sounds like a good idea! > Other possible notebook tabs to add are those displayed by piklab when selecting > a specific device: > - Device information: basic features of the selected PIC + link to microchip.com > - Memory Map > - Voltage-frequency Graphs > - Pin diagrams, possibly with the PGD, PGC, Vdd, MCLR, GND pins highlighted. > > 4) currently when issuing a command which provokes a read/write operation on the > USB, the program "hangs"; the UI doesn't redraw and the program does not respond > to user. This is because those operations should be done in a secondary > thread... this shouldn't be difficult to do; a simple wxThread should be enough. > Actually this is my first wxWidgets program ever, so I didn't even know such a thing would exist. > > I'm ready to help with any of these tasks... > If you give me your sourceforge name, I'll make you member of the developers group and give you SVN write access. Cheers, Frans |
From: Francesco M. <f18...@ya...> - 2008-11-22 00:37:15
|
Hi, Frans Schreuder ha scritto: > Hi Francesco, >> Hi, >> using the upp_wx program I've thought to the following >> changes/improvements... let me know what you think of them. >> >> 1) the toolbar currently uses two radio boxes to inform the user about what >> hardware has been detected. This is a misuse of the checkbox widget; in fact in >> upp_wx they aren't used for user input just as "read-only" displays, isn't it? >> > You can actually click those radio boxes, if you have used the > bootloader and then want to switch to usbpicprog mode, you can use them. Strange; I've tried to use it to switch from "usbpicprog" to "bootloader" but it prints various stuff on the console (see the end of this mail for a copy and paste of them) and then upp_wx automatically reselects "usbpicprog". > Also in the rare case when you have an usbpicprog and a bootloader > connected, you can choose one of them. this is not a general solution however; it could happen you have more than 1 usbpicprog and/or more than 1 bootloader connected. I'd suggest adding an "Actions->Select programmer" option which displays more info about the attached hardware and lets you choose the usbpicprog/bootloader you want. In any case using two radioboxes in the toolbar isn't "clear" IMHO... >> I'm ready to help with any of these tasks... >> > If you give me your sourceforge name, I'll make you member of the > developers group and give you SVN write access. Thanks! My SF username is "frm"... Bye, Francesco =========================== USB debug enabled, remove #define USB_DEBUG 10 in hardware.cpp to disable it usb_set_debug: Setting debugging level to 2 (on) ID: 0x11246 usb_os_init: Found USB VFS at /dev/bus/usb usb_os_find_busses: Found 005 usb_os_find_busses: Found 004 usb_os_find_busses: Found 003 usb_os_find_busses: Found 002 usb_os_find_busses: Found 001 usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 001 on 005 error obtaining child information: Operation not permitted usb_os_find_devices: Found 002 on 004 usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 001 on 004 error obtaining child information: Inappropriate ioctl for device error obtaining child information: Operation not permitted usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 001 on 003 error obtaining child information: Operation not permitted usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 001 on 002 error obtaining child information: Operation not permitted usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 005 on 001 skipped 1 class/vendor specific interface descriptors usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 004 on 001 skipped 1 class/vendor specific interface descriptors skipped 1 class/vendor specific interface descriptors usb_os_find_devices: couldn't get connect info usb_os_find_devices: Found 001 on 001 error obtaining child information: Operation not permitted error obtaining child information: Operation not permitted error obtaining child information: Operation not permitted USB debug enabled, remove #define USB_DEBUG 10 in hardware.cpp to disable it usb_set_debug: Setting debugging level to 2 (on) ID: 0x11246 =========================== -- |
From: Frans S. <fra...@gm...> - 2008-11-22 16:21:58
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> Hi Francesco<br> <br> <blockquote cite="mid:492...@ya..." type="cite"> <pre wrap=""><!---->Strange; I've tried to use it to switch from "usbpicprog" to "bootloader" but it prints various stuff on the console (see the end of this mail for a copy and paste of them) and then upp_wx automatically reselects "usbpicprog". </pre> </blockquote> That's true, because you don't have the bootloader connected, it will look for something else.<br> It might not be very logical for you, but some other people might like to click the checkboxes.<br> the things that you pasted below is just libusb debug info...<br> <blockquote cite="mid:492...@ya..." type="cite"> <pre wrap="">I'd suggest adding an "Actions->Select programmer" option which displays more info about the attached hardware and lets you choose the usbpicprog/bootloader you want. In any case using two radioboxes in the toolbar isn't "clear" IMHO... </pre> </blockquote> In the actions menu, there's already "Connect Usbpicprog" or "Connect Bootloader" it does the same thing as the radio buttons. Maybe this can be done in a different way, but for me it is no priority - let's concentrate on the other improvements you suggested before like the config bits from the xml files etc.<br> <blockquote cite="mid:492...@ya..." type="cite"> <pre wrap=""> </pre> <pre wrap=""><!---->Thanks! My SF username is "frm"... </pre> </blockquote> <pre wrap="">I added you to the developers! I think it's a good idea to make a branch before adding all the things like the xml files and the thread. Cheers, Frans </pre> <br> </body> </html> |
From: Francesco M. <f18...@ya...> - 2008-11-24 00:52:51
|
Hi, Frans Schreuder ha scritto: > I added you to the developers! Thanks! >I think it's a good idea to make a branch before adding all the things like the xml files and the thread. indeed; today I've focused on writing a general-purpose class for adding easily pausable threads directly in wxWidgets (it was a long time I planned to write it; this is the good occasion to remove it from my TODO list :)). I hope to be able to complete it tomorrow so that I can test it in UPP later this week. I'd call the branch "upp_wx_thread"... Bye, Francesco -- |
From: Frans S. <fra...@gm...> - 2008-11-24 07:29:20
|
Francesco Montorsi wrote: > Hi, > > Frans Schreuder ha scritto: > >> I added you to the developers! >> > Thanks! > > >I think it's a good idea to make a branch before adding all the things like > the xml files and the thread. > indeed; today I've focused on writing a general-purpose class for adding easily > pausable threads directly in wxWidgets (it was a long time I planned to write > it; this is the good occasion to remove it from my TODO list :)). I hope to be > able to complete it tomorrow so that I can test it in UPP later this week. > > I'd call the branch "upp_wx_thread"... > > Perfect! > Bye, > Francesco > > > |
From: Frans S. <fra...@gm...> - 2008-11-24 14:45:21
|
Hi, > I'd call the branch "upp_wx_thread"... > I see you've copied the whole trunk into upp_wx_thread I think it's better to only copy upp_wx there, the other things don't need any change, especially not the bootloader and the programming specs! Cheers, Frans |
From: Francesco M. <f18...@ya...> - 2008-11-24 16:50:29
|
Frans Schreuder ha scritto: > Hi, >> I'd call the branch "upp_wx_thread"... >> > I see you've copied the whole trunk into upp_wx_thread yes; in the other open source projects I work into, the rule is to branch the entire contents of "trunk", no matter what you're going to touch... if that's a problem I think it shouldn't be difficult to fix it. > I think it's better to only copy upp_wx there, the other things don't > need any change, especially not the bootloader and the programming specs! indeed, I'm touching exclusively the upp_wx contents... Francesco -- |
From: Frans S. <fra...@gm...> - 2008-11-28 08:56:53
|
Hi, There are a couple of things I really like about what you did: * I think you are doing a good job, the filenames you changed make sense and also some of the object names (like readHexfile wasn't only reading anymore) * I like the tabbed layout you created * It is good to have the form-builder project up to date (I stopped using it, because I only used it as a template and found it more convenient to edit the code itself) * The bakefiles seem a good idea, since people can now build the project from their favourite IDE. (Though I have no idea what to do with it, and I don't even want to know because I just like my good old automake things) There are also a couple of things I dislike about what you did: * Why have you removed all the "&" signs from the strings? They should be in the menu and now also the language files are all corrupted... * Why have you removed the progress bar from the status bar? I liked it there, now you can't see any progress anymore? or do you have another idea for it? (please communicate before you change big things like that!) * I thought I was clear about the checkboxes for usbpicprog / bootloader. The fact that you don't like them doesn't mean that we agreed that they should be removed... * I miss some things in the menu like Preferences, Connect Usbpicprog etc. I think I have not made them through formbuilder, but I implemented them in cpp. If you want to fallback on formbuilder it's ok, but we will also have to implement them again. * My window doesn't resize anymore (well, the Y scale resizes, but in the X-direction it is maximized and I am unable to drag the size. Maybe this is an ubuntu / wxWidgets 2.8.0 thing, and I haven't spent much time on finding the problem in the code, but it needs a fix. Regards, Frans |
From: Francesco M. <f18...@ya...> - 2008-11-28 12:49:54
|
Hi Frans, first of all let me say that the upp_wx_thread branch is far from completed; I still need to implement the thread/XML code! It will take me some time and I have some university commitment in the next weeks which reduce my free time... Frans Schreuder ha scritto: > There are a couple of things I really like about what you did: > > * I think you are doing a good job, the filenames you changed make > sense and also some of the object names (like readHexfile wasn't > only reading anymore) ok, thanks > * I like the tabbed layout you created good! > * It is good to have the form-builder project up to date (I stopped > using it, because I only used it as a template and found it more > convenient to edit the code itself) indeed it's very useful to use a GUI editor like wxFormBuilder for doing most of the GUI creation work; at beginning I didn't see how many changes were done in the CPP and not in the wxFB project file (I noticed some hand-made modifications in the files but I thought was something small)... when I noticed it I already did make the layout changes with wxFB, so I "restored" it completely. > * The bakefiles seem a good idea, since people can now build the > project from their favourite IDE. yes, on wxMSW that's much easier now to build upp_wx :) > (Though I have no idea what to > do with it, and I don't even want to know because I just like my > good old automake things) because of the bakefile itself, there's mostly nothing to know in any case :) The only thing you may need/want to know is that you should run "bakefile_gen" in the upp_wx/build/bakefile folder when you add/remove/rename source/include files. > There are also a couple of things I dislike about what you did: > > * Why have you removed all the "&" signs from the strings? They > should be in the menu and now also the language files are all > corrupted... indeed. It wasn't a wanted change. It's just that probably the & signs were added manually in the CPP file and I still haven't had time to add them in the wxFB project. > * Why have you removed the progress bar from the status bar? I liked > it there, now you can't see any progress anymore? or do you have > another idea for it? (please communicate before you change big > things like that!) the idea is that while you program/read/verify/etc the attached PIC device through the UPP programmer, you - want to have your GUI working as usual, e.g. redrawing when needed (something that actually doesn't happen, because of the mono-thread design). - want the user to be unable to take other actions (e.g. editing code/config/data areas, load other HEX files, etc) until the operation has been completed or cancelled. The best way to satisfy the two points above is to make a modal wxProgressDialog (or something like that) which is updated through events from a secondary worker thread (see also the 'thread' wx sample). This means that a progress bar in the status bar isn't a good choice since it doesn't satisfy 2nd point even if it was updated from a secondary thread... > * I thought I was clear about the checkboxes for usbpicprog / > bootloader. The fact that you don't like them doesn't mean that we > agreed that they should be removed... I've just commented them out, not removed; it's just that I need some more time to re-enable everything I had to temporary disable. > * I miss some things in the menu like Preferences, Connect > Usbpicprog etc. I think I have not made them through formbuilder, > but I implemented them in cpp. If you want to fallback on > formbuilder it's ok, but we will also have to implement them again. see above :); it's stuff temporary disabled. Btw I'd put the "&Preferences..." menu item under "Edit" menu and thus I'd add it in the wxFB project. > * My window doesn't resize anymore (well, the Y scale resizes, but > in the X-direction it is maximized and I am unable to drag the > size. Maybe this is an ubuntu / wxWidgets 2.8.0 thing, and I > haven't spent much time on finding the problem in the code, but it > needs a fix. It looks like a bug in wx 2.8.0; I'm using Ubuntu 8.04 with the stock wx 2.8.7 installed: frm@ubuntu:~/work/upp_wx_thread/upp_wx$ wx-config --list Default config is gtk2-unicode-release-2.8 Default config will be used for output Alternate matches: base-unicode-debug-2.8 base-unicode-release-2.8 gtk2-unicode-debug-2.8 frm@ubuntu:~/work/upp_wx_thread/upp_wx$ wx-config --version 2.8.7 and I don't see this bug... Bye, Francesco -- |
From: Frans S. <fra...@gm...> - 2008-11-28 13:09:39
|
> It looks like a bug in wx 2.8.0; I'm using Ubuntu 8.04 with the stock wx 2.8.7 > installed: > Ok, but I think it should also work with the default libraries which are installed in Ubuntu... I think we should make it also compatible with 2.8.0 |
From: Francesco M. <f18...@ya...> - 2008-11-29 16:06:50
|
Frans Schreuder ha scritto: > >> It looks like a bug in wx 2.8.0; I'm using Ubuntu 8.04 with the stock wx 2.8.7 >> installed: >> > Ok, but I think it should also work with the default libraries which are > installed in Ubuntu... I think we should make it also compatible with 2.8.0 however I've seen that wx2.8.9 and in particular wx2.9 have more stable implementations of wxGrid; I'd suggest to build and link statically upp_wx against wx2.9 (trunk)... the executable doesn't get too much bigger... Francesco -- |
From: Frans S. <fra...@gm...> - 2008-11-30 11:19:05
|
> > Frans Schreuder ha scritto: > > > >> It looks like a bug in wx 2.8.0; I'm using Ubuntu 8.04 with the stock wx > 2.8.7 > >> installed: > >> > > Ok, but I think it should also work with the default libraries which are > > installed in Ubuntu... I think we should make it also compatible with > 2.8.0 > however I've seen that wx2.8.9 and in particular wx2.9 have more stable > implementations of wxGrid; I'd suggest to build and link statically upp_wx > against wx2.9 (trunk)... the executable doesn't get too much bigger... > I agree, let's do so! > > Francesco > > > -- > > > > > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Usbpicprog-technical mailing list > Usb...@li... > https://lists.sourceforge.net/lists/listinfo/usbpicprog-technical > |