Re: [Usbpicprog-technical] upp_wx GUI

[Francesco M. <f18...@ya...>]

Hi Frans,
     first of all let me say that the upp_wx_thread branch is far from 
completed; I still need to implement the thread/XML code! It will take me some 
time and I have some university commitment in the next weeks which reduce my 
free time...

Frans Schreuder ha scritto:
> There are a couple of things I really like about what you did:
> 
>     * I think you are doing a good job, the filenames you changed make
>       sense and also some of the object names (like readHexfile wasn't
>       only reading anymore)
ok, thanks

>     * I like the tabbed layout you created
good!

>     * It is good to have the form-builder project up to date (I stopped
>       using it, because I only used it as a template and found it more
>       convenient to edit the code itself)
indeed it's very useful to use a GUI editor like wxFormBuilder for doing most of 
the GUI creation work; at beginning I didn't see how many changes were done in 
the CPP and not in the wxFB project file (I noticed some hand-made modifications 
in the files but I thought was something small)... when I noticed it I already 
did make the layout changes with wxFB, so I "restored" it completely.

>     * The bakefiles seem a good idea, since people can now build the
>       project from their favourite IDE.
yes, on wxMSW that's much easier now to build upp_wx :)

> (Though I have no idea what to
>       do with it, and I don't even want to know because I just like my
>       good old automake things)
because of the bakefile itself, there's mostly nothing to know in any case :)
The only thing you may need/want to know is that you should run "bakefile_gen" 
in the upp_wx/build/bakefile folder when you add/remove/rename source/include files.

> There are also a couple of things I dislike about what you did:
> 
>     * Why have you removed all the "&" signs from the strings? They
>       should be in the menu and now also the language files are all
>       corrupted...
indeed. It wasn't a wanted change. It's just that probably the & signs were 
added manually in the CPP file and I still haven't had time to add them in the 
wxFB project.

>     * Why have you removed the progress bar from the status bar? I liked
>       it there, now you can't see any progress anymore? or do you have
>       another idea for it? (please communicate before you change big
>       things like that!)
the idea is that while you program/read/verify/etc the attached PIC device 
through the UPP programmer, you
- want to have your GUI working as usual, e.g. redrawing when needed (something 
that actually doesn't happen, because of the mono-thread design).
- want the user to be unable to take other actions (e.g. editing 
code/config/data areas, load other HEX files, etc) until the operation has been 
completed or cancelled.

The best way to satisfy the two points above is to make a modal wxProgressDialog 
(or something like that) which is updated through events from a  secondary 
worker thread (see also the 'thread' wx sample).
This means that a progress bar in the status bar isn't a good choice since it 
doesn't satisfy 2nd point even if it was updated from a secondary thread...

>     * I thought I was clear about the checkboxes for usbpicprog /
>       bootloader. The fact that you don't like them doesn't mean that we
>       agreed that they should be removed...
I've just commented them out, not removed; it's just that I need some more time 
to re-enable everything I had to temporary disable.

>     * I miss some things in the menu like Preferences, Connect
>       Usbpicprog etc. I think I have not made them through formbuilder,
>       but I implemented them in cpp. If you want to fallback on
>       formbuilder it's ok, but we will also have to implement them again.
see above :); it's stuff temporary disabled.
Btw I'd put the "&Preferences..." menu item under "Edit" menu and thus I'd add 
it in the wxFB project.

>     * My window doesn't resize anymore (well, the Y scale resizes, but
>       in the X-direction it is maximized and I am unable to drag the
>       size. Maybe this is an ubuntu / wxWidgets 2.8.0 thing, and I
>       haven't spent much time on finding the problem in the code, but it
>       needs a fix.
It looks like a bug in wx 2.8.0; I'm using Ubuntu 8.04 with the stock wx 2.8.7 
installed:

frm@ubuntu:~/work/upp_wx_thread/upp_wx$ wx-config --list

     Default config is gtk2-unicode-release-2.8

   Default config will be used for output

   Alternate matches:
     base-unicode-debug-2.8
     base-unicode-release-2.8
     gtk2-unicode-debug-2.8

frm@ubuntu:~/work/upp_wx_thread/upp_wx$ wx-config --version
2.8.7

and I don't see this bug...

Bye,
Francesco
--