|
From: Frans S. <fra...@gm...> - 2008-11-28 08:56:53
|
Hi,
There are a couple of things I really like about what you did:
* I think you are doing a good job, the filenames you changed make
sense and also some of the object names (like readHexfile wasn't
only reading anymore)
* I like the tabbed layout you created
* It is good to have the form-builder project up to date (I stopped
using it, because I only used it as a template and found it more
convenient to edit the code itself)
* The bakefiles seem a good idea, since people can now build the
project from their favourite IDE. (Though I have no idea what to
do with it, and I don't even want to know because I just like my
good old automake things)
There are also a couple of things I dislike about what you did:
* Why have you removed all the "&" signs from the strings? They
should be in the menu and now also the language files are all
corrupted...
* Why have you removed the progress bar from the status bar? I liked
it there, now you can't see any progress anymore? or do you have
another idea for it? (please communicate before you change big
things like that!)
* I thought I was clear about the checkboxes for usbpicprog /
bootloader. The fact that you don't like them doesn't mean that we
agreed that they should be removed...
* I miss some things in the menu like Preferences, Connect
Usbpicprog etc. I think I have not made them through formbuilder,
but I implemented them in cpp. If you want to fallback on
formbuilder it's ok, but we will also have to implement them again.
* My window doesn't resize anymore (well, the Y scale resizes, but
in the X-direction it is maximized and I am unable to drag the
size. Maybe this is an ubuntu / wxWidgets 2.8.0 thing, and I
haven't spent much time on finding the problem in the code, but it
needs a fix.
Regards,
Frans
|