Re: [usbip-devel] [PATCH 13/15] staging: usbip: userspace: libsrc: cleanup parsing

[Dan C. <dan...@or...>]

On Thu, Apr 04, 2013 at 10:10:10PM +0300, Dan Carpenter wrote:
> > +		if (buf[0] == 'P' && buf[1] == 'H' && buf[2] == 'Y' &&
> > +		    buf[3] == 'S' && buf[4] == 'D' &&
> > +		    buf[5] == 'E' && buf[6] == 'S' && /*isspace(buf[7])*/
> > +		    buf[7] == ' ') {
> >  			continue;
> 
> 	if (strncmp(buf, "PHYSDES ", 8) == 0)
> 		continue;

Btw, this is obviously something that could be cleaned up in a later
patch.  Generally, if you didn't introduce it and it's not a bug
then fixing it in a later patch is fine.

regards,
dan carpenter