<pedantic>unsigned char is not always identical to uint8_t.</pedantic>
The attached patch fixes this bug.
Two questions here:
Shouldn't we change the prototypes in include/urjtag/parport.h accordingly?
I assume this affects direct.c and ppi.c as well?
I'll do these changes as well if you agree.
proposed patch version 2
You are right, include/urjtag/parport.h and src/tap/parport/direct.c will need to change as well. I cannot confirm on src/tap/parport/ppi.c because I do not have a NetBSD system handy, but I believe that this one must remain uint8_t.
Also, outb has the following prototype according to /usr/include/sys/io.h on my amd64 and i386 Linux systems:
outb (unsigned char, unsigned short int);
Updated attached patch to change include/urjtag/parport.h, src/tap/parport.c, src/tap/parport/direct.c and src/tap/parport/ppi.c, as well as src/tap/parport/ppdev.c.
Applied to urjtag/ as r1598, thanks!
Log in to post a comment.