uriparser-users — Mailing list for discussion among and with uriparser users

[Uriparser-users] uriparser 0.9.7 released

[Sebastian P. <seb...@pi...>]

Hi!


Two days ago uriparser 0.9.7 has been released.  Version 0.9.7 fixes
multiple issues with parsing IPv6 URIs, most importantly.  For more
details, please check out the change log [1].

If you maintain uriparser packaging or a bundled copy of uriparser or a
pinned version of uriparser somewhere, please update to 0.9.7 — thank you!

Best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.7/ChangeLog

[Uriparser-users] uriparser 0.9.6 released, includes security fixes

[Sebastian P. <seb...@pi...>]

Hi!


Earlier today uriparser 0.9.6 has been released.  Version 0.9.6 comes
with **security fixes** for vulnerabilities CVE-2021-46141 and
CVE-2021-46142, as well as minor fixes related to the build system,
compiler warnings and documentation.  For more details please check the
change log [1].

Last but not least: If you maintain uriparser packaging or a bundled 
version of uriparser somewhere, please update to 0.9.6 — thank you!

Thanks and best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.6/ChangeLog

[Uriparser-users] uriparser 0.9.5 released

[Sebastian P. <seb...@pi...>]

Hi!


( An HTML blog-post version of this mail is up at:
  https://blog.hartwork.org/posts/uriparser-095-released/ )


A few hours ago uriparser 0.9.5 has been released.  Version 0.9.5 comes
with improvements to the build system and one key bugfix that affects
both resolution of URI references and normalization of URIs. For more
details please check the change log [1].

Last but not least:
If you maintain uriparser packaging or a bundled version of uriparser
somewhere, please update to 0.9.5 — thank you!

Best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.5/ChangeLog

[Uriparser-users] uriparser 0.9.4 released

[Sebastian P. <seb...@pi...>]

Hi!


( An HTML blog-post version of this mail is up at:
  https://blog.hartwork.org/posts/uriparser-094-released/ )


A few minutes ago uriparser 0.9.4 has been released.  Version 0.9.4
comes with a number of minor improvements to the build system
and four new functions — uriMakeOwner[AW] and `uriMakeOwnerMm[AW] —
that make UriUri[AW] instances independent of the original URI string.

For more details please check the change log at [1].

Last but not least:
If you maintain uriparser packaging or a bundled version of uriparser
somewhere, please update to 0.9.4.  Thank you!


Best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.4/ChangeLog

[Uriparser-users] uriparser 0.9.3 released

[Sebastian P. <seb...@pi...>]

Hi!


( An HTML blog-post version of this mail is up at:
  https://blog.hartwork.org/posts/uriparser-093-released/ )


A few minutes ago uriparser 0.9.3 has been released.  0.9.3 is a fix-up
to 0.9.2.  Combined, releases 0.9.2 and 0.9.3 feature:

 - Migration from GNU autotools to CMake

 - Link fixes for use of uriparser from C++ code

 - Library visibility fixes / introduction of -fvisibility=hidden

For more details please check the change log at [1].

Last but not least:
If you maintain uriparser packaging or a bundled version of uriparser
somewhere, please update to 0.9.3.  Thank you!

Best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.3/ChangeLog

[Uriparser-users] uriparser 0.9.1 released, includes security fixes

[Sebastian P. <seb...@pi...>]

Hi!


( An HTML blog-post version of this mail is up at:
  https://blog.hartwork.org/posts/uriparser-091-released/ )


A few days ago uriparser 0.9.1 has been released. Some highlights of
version 0.9.1 include:

 - A security fix for an out-of-bounds read reported by Joergen Ibsen

 - Improvements regarding the accuracy of errorPos that is used to
   communicate the precise location of parse errors

For more details please check the change log at [1].

Last but not least:
If you maintain uriparser packaging or a bundled version of uriparser
somewhere, please update to 0.9.1.  Thank you!

Best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.1/ChangeLog

[Uriparser-users] uriparser 0.9.0 released, includes security fixes

[Sebastian P. <seb...@pi...>]

Hi!


( An HTML blog-post version of this mail is up at:
  https://blog.hartwork.org/posts/uriparser-090-released/ )


Earlier today uriparser 0.9.0 has been released.  Some highlights of
version 0.9.0 include:

 - Security fixes for issues uncovered by the Google Autofuzz team

 - Support for custom memory managers for when libc calloc, free,
   malloc, realloc, reallocarray are not a good fit to your scenario

 - New uriParseSingleUri* convenience functions to simplify user code

 - Full support for strict C89 restored and enforced by CI

I cannot over-emphasize how helpful AddressSanitizer has been in making
this new release.  If you get stuck while writing a custom memory
manager, please check out helpers uriTestMemoryManager and
uriCompleteMemoryManager.

For more details please check the change log at [1].

Last but not least:
If you maintain uriparser packaging or a bundled version of uriparser
somewhere, please update to 0.9.0.  Thanks you!

Best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.9.0/ChangeLog

[Uriparser-users] uriparser 0.8.6 released

[Sebastian P. <seb...@pi...>]

Hi!


A few days ago uriparser 0.8.6 has been released.  Version 0.8.6 is a
bugfix release including a nasty bug that has potential to crash
applications when parsing certain URIs (like "//:%aa@", excluding
quotes).  For more details please check the change log at [1].

If you maintain uriparser packaging or a bundled version of uriparser
somewhere, please update to 0.8.6.

Thanks and best



Sebastian


[1] https://github.com/uriparser/uriparser/blob/uriparser-0.8.6/ChangeLog

[Uriparser-users] uriparser 0.8.5 released + moved to GitHub

[Sebastian P. <seb...@pi...>]

Hi!


Just a quick heads-up that uriparser 0.8.5 with bugfixes has been
released.  It has also moved from SourceForge to GitHub:

  Website: https://uriparser.github.io/

  Git: https://github.com/uriparser/uriparser

It would be cool if you could update any uriparser you have power to
update and report any issues you run into on GitHub.  Thanks a bunch!

Best



Sebastian Pipping

Re: [Uriparser-users] GCC warning patches

[Cunningham, J. <Joe...@ga...>]

> -----Original Message-----
> From: Sebastian Pipping [mailto:seb...@pi...]
> Sent: Saturday, December 02, 2017 7:49 AM
> To: uri...@li...
> Subject: Re: [Uriparser-users] GCC warning patches
>
> Hi Joel,
>
>
> On 01.12.2017 23:30, Cunningham, Joel wrote:
> > I was able to resolve issue by passing -D_GLIBCXX_USE_CXX11_ABI=0 to
> configure, i.e. './configure CXXFLAGS=-D_GLIBCXX_USE_CXX11_ABI=0 &&
> make clean all check'
>
> Nice!  I wonder if we should do a link-test against cpptest in configure and
> add that define ourselves as-needed so we can handle both cases
> transparently.
>

Sounds like a good idea.  Might be a while before I can spin up on this (I'm pretty new to writing configure scripts) and provide a patch.

>
> > Now that I can build the unit test, I'll mess around with adding a
> > header for those test functions
>
> I think we should still get the symbol out of the .so file.  I vaguely remember
> an idea about adding having the test code against the related .o/.lo file, as
> well.
>

I looked at the headers and it does seem a little complicated.  test.cpp calls APIs that are only in src/ versus the public API in include/uriparser.  Now I know why test.cpp has local declarations:

extern "C" {
UriBool uri_TESTING_ONLY_ParseIpSixA(const char * text);
UriBool uri_TESTING_ONLY_ParseIpFourA(const char * text);
int uriCompareRangeA(const UriTextRangeA * a, const UriTextRangeA * b);
}

Seems like exposing these in a header in include/uriparser is not what we want to do, so I'm not sure.  For now I'm fine continuing to suppress -Werror-missing-prototypes and -Werror-missing-declarations

Joel


________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [Uriparser-users] GCC warning patches

[Sebastian P. <seb...@pi...>]

Hi Joel,


On 01.12.2017 23:30, Cunningham, Joel wrote:
> I was able to resolve issue by passing -D_GLIBCXX_USE_CXX11_ABI=0 to configure, i.e. './configure CXXFLAGS=-D_GLIBCXX_USE_CXX11_ABI=0 && make clean all check'

Nice!  I wonder if we should do a link-test against cpptest in configure
and add that define ourselves as-needed so we can handle both cases
transparently.


> Now that I can build the unit test, I'll mess around with adding a header for those test functions

I think we should still get the symbol out of the .so file.  I vaguely
remember an idea about adding having the test code against the related
.o/.lo file, as well.

Best



Sebastian

Re: [Uriparser-users] GCC warning patches

[Cunningham, J. <Joe...@ga...>]

> -----Original Message-----
> From: Sebastian Pipping [mailto:seb...@pi...]
> Sent: Wednesday, November 29, 2017 4:48 PM
> To: uri...@li...
> Subject: Re: [Uriparser-users] GCC warning patches
>
> Hi Joel,
>
>
> I'll focus on the build issue for now for a quicker reply:
>
>
> On 29.11.2017 19:05, Cunningham, Joel wrote:
> > Also, I'm trying to build the tests on Ubuntu 17.10, but am currently getting
> a link failure.  I have libcpptest version 1.1.2-0ubuntu2 installed (configure
> detects it).  I don't see any change in cpptest API that would mean
> TEST_ADD/register_test is not available.  Any ideas?
> >
> > $ make check
> > Making check in .
> > make[1]: Entering directory '/home/joel/repos/uriparser'
> > make  test/uriparser_test
> > make[2]: Entering directory '/home/joel/repos/uriparser'
> > /bin/bash ./libtool  --tag=CXX   --mode=link g++  -g -O2 -lcpptest  -o
> test/uriparser_test test/FourSuite.o test/VersionSuite.o test/test.o
> liburiparser.la
> > libtool: link: g++ -g -O2 -o test/.libs/uriparser_test
> > test/FourSuite.o test/VersionSuite.o test/test.o  -lcpptest
> > ./.libs/liburiparser.so
> > test/test.o: In function `FourSuite::FourSuite()':
> > /home/joel/repos/uriparser/test/FourSuite.h:37: undefined reference to
> `Test::Suite::register_test(void (Test::Suite::*)(),
> std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
> > const&)'
> > /home/joel/repos/uriparser/test/FourSuite.h:38: undefined reference to
> `Test::Suite::register_test(void (Test::Suite::*)(),
> std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
> > const&)'
> > /home/joel/repos/uriparser/test/FourSuite.h:39: undefined reference to
> `Test::Suite::register_test(void (Test::Suite::*)(),
> std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
> > const&)'
> > /home/joel/repos/uriparser/test/FourSuite.h:40: undefined reference to
> `Test::Suite::register_test(void (Test::Suite::*)(),
> std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
> > const&)'
> > /home/joel/repos/uriparser/test/FourSuite.h:41: undefined reference to
> `Test::Suite::register_test(void (Test::Suite::*)(),
> std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
> > const&)'
> > test/test.o:/home/joel/repos/uriparser/test/FourSuite.h:42: more
> > undefined references to `Test::Suite::register_test(void
> > (Test::Suite::*)(), std::__cxx11::basic_string<char,
> > std::char_traits<char>, std::allocator<char> > const&)' follow
> > collect2: error: ld returned 1 exit status
> > Makefile:896: recipe for target 'test/uriparser_test' failed
> > make[2]: *** [test/uriparser_test] Error 1
> > make[2]: Leaving directory '/home/joel/repos/uriparser'
> > Makefile:1511: recipe for target 'check-am' failed
> > make[1]: *** [check-am] Error 2
> > make[1]: Leaving directory '/home/joel/repos/uriparser'
> > Makefile:1062: recipe for target 'check-recursive' failed
> > make: *** [check-recursive] Error 1
>
> I get (more or less) the same over here.
>
> Some form of register_test is in there:
>
> # objdump -TC /usr/lib64/libcpptest.so | fgrep register_test
> 000000000000fdc0 g    DF .text  0000000000000211  Base
> Test::Suite::register_test(void (Test::Suite::*)(), std::string const&)
>
> The "__cxx11" in the output strikes me.  I was wondering if we're dealing
> with something related to this thing here (not specific to Gentoo)
>
>
> https://www.gentoo.org/support/news-items/2014-10-26-
> gcc_4_7_introduced_new_c++11_abi.html
>
> but it seems that configuring with -std=gnu++98 like
>
>   ./configure CXXFLAGS=-std=gnu++98 && make clean all check
>
> does not get the cxx11 out of the long version of std::string.
>

I did a little more investigation and figured out the problem.  It does have to do with the GCC ABI break you mentioned.  I found more information here: https://stackoverflow.com/questions/33394934/converting-std-cxx11string-to-stdstring

I have GCC 7.20 on my system and the libcpptest system library has apparently not been re-compiled after the ABI break.  So uriparser was being compiled with the new ABI, but then trying to link against libcpptest with the old.

I was able to resolve issue by passing -D_GLIBCXX_USE_CXX11_ABI=0 to configure, i.e. './configure CXXFLAGS=-D_GLIBCXX_USE_CXX11_ABI=0 && make clean all check'

Now that I can build the unit test, I'll mess around with adding a header for those test functions

Joel

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [Uriparser-users] GCC warning patches

[Sebastian P. <seb...@pi...>]

Hi Joel,


I'll focus on the build issue for now for a quicker reply:


On 29.11.2017 19:05, Cunningham, Joel wrote:
> Also, I'm trying to build the tests on Ubuntu 17.10, but am currently getting a link failure.  I have libcpptest version 1.1.2-0ubuntu2 installed (configure detects it).  I don't see any change in cpptest API that would mean TEST_ADD/register_test is not available.  Any ideas?
> 
> $ make check
> Making check in .
> make[1]: Entering directory '/home/joel/repos/uriparser'
> make  test/uriparser_test
> make[2]: Entering directory '/home/joel/repos/uriparser'
> /bin/bash ./libtool  --tag=CXX   --mode=link g++  -g -O2 -lcpptest  -o test/uriparser_test test/FourSuite.o test/VersionSuite.o test/test.o liburiparser.la
> libtool: link: g++ -g -O2 -o test/.libs/uriparser_test test/FourSuite.o test/VersionSuite.o test/test.o  -lcpptest ./.libs/liburiparser.so
> test/test.o: In function `FourSuite::FourSuite()':
> /home/joel/repos/uriparser/test/FourSuite.h:37: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
> /home/joel/repos/uriparser/test/FourSuite.h:38: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
> /home/joel/repos/uriparser/test/FourSuite.h:39: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
> /home/joel/repos/uriparser/test/FourSuite.h:40: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
> /home/joel/repos/uriparser/test/FourSuite.h:41: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
> test/test.o:/home/joel/repos/uriparser/test/FourSuite.h:42: more undefined references to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' follow
> collect2: error: ld returned 1 exit status
> Makefile:896: recipe for target 'test/uriparser_test' failed
> make[2]: *** [test/uriparser_test] Error 1
> make[2]: Leaving directory '/home/joel/repos/uriparser'
> Makefile:1511: recipe for target 'check-am' failed
> make[1]: *** [check-am] Error 2
> make[1]: Leaving directory '/home/joel/repos/uriparser'
> Makefile:1062: recipe for target 'check-recursive' failed
> make: *** [check-recursive] Error 1

I get (more or less) the same over here.

Some form of register_test is in there:

# objdump -TC /usr/lib64/libcpptest.so | fgrep register_test
000000000000fdc0 g    DF .text  0000000000000211  Base
Test::Suite::register_test(void (Test::Suite::*)(), std::string const&)

The "__cxx11" in the output strikes me.  I was wondering if we're
dealing with something related to this thing here (not specific to Gentoo)


https://www.gentoo.org/support/news-items/2014-10-26-gcc_4_7_introduced_new_c++11_abi.html

but it seems that configuring with -std=gnu++98 like

  ./configure CXXFLAGS=-std=gnu++98 && make clean all check

does not get the cxx11 out of the long version of std::string.

Best



Sebastian

Re: [Uriparser-users] GCC warning patches

[Cunningham, J. <Joe...@ga...>]

> -----Original Message-----
> From: Sebastian Pipping [mailto:seb...@pi...]
> Sent: Wednesday, November 29, 2017 8:27 AM
> To: uri...@li...
> Subject: Re: [Uriparser-users] GCC warning patches
>
> Hi Joel,
>
>
> On 28.11.2017 00:03, Cunningham, Joel wrote:
> > Hi,
> >
> > I have attached two patches to address -Werror-parentheses and
> > -Werror-uninitialized issues found with GCC 4.9 and uriparser
>
> thanks, applied both now.
>

Great, thank you :)

>
> > There are also instances of -Werror-missing-prototypes and -Werror-
> missing-declarations for the following functions (which don't seem to have
> declarations):
> >
> > RemoveBaseUriImpl
> > _TESTING_ONLY_ParseIpSix
> > _TESTING_ONLY_ParseIpFour
> >
> > Should RemoveBaseUriImpl be declared static since it's only referenced in
> UriShorten.c and declared at the top of the file?
>
> Yes, made static now.

Declaring this static resolved the -Werror-missing-prototypes and -Werror-missing-declarations errors without adding forward declaration!

>
> It's warning clean for GCC 5.4 with -Wextra here now.  I'm short on time, but
> patches welcome to go beyond that.
>
>
> > I'm not sure the use of the __TESTING_ONLY functions, maybe these
> should be local too?
>
> The test suite needs these symbols so the build system would need some
> adjustment if these become static.  Still need to fix the same in Expat as well.
> If you have a minute, patches are welcome.
>

What do you think about creating a UriTest.h header and adding declarations there?  Then we could include it in test.cpp

Also, I'm trying to build the tests on Ubuntu 17.10, but am currently getting a link failure.  I have libcpptest version 1.1.2-0ubuntu2 installed (configure detects it).  I don't see any change in cpptest API that would mean TEST_ADD/register_test is not available.  Any ideas?

$ make check
Making check in .
make[1]: Entering directory '/home/joel/repos/uriparser'
make  test/uriparser_test
make[2]: Entering directory '/home/joel/repos/uriparser'
/bin/bash ./libtool  --tag=CXX   --mode=link g++  -g -O2 -lcpptest  -o test/uriparser_test test/FourSuite.o test/VersionSuite.o test/test.o liburiparser.la
libtool: link: g++ -g -O2 -o test/.libs/uriparser_test test/FourSuite.o test/VersionSuite.o test/test.o  -lcpptest ./.libs/liburiparser.so
test/test.o: In function `FourSuite::FourSuite()':
/home/joel/repos/uriparser/test/FourSuite.h:37: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/joel/repos/uriparser/test/FourSuite.h:38: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/joel/repos/uriparser/test/FourSuite.h:39: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/joel/repos/uriparser/test/FourSuite.h:40: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/joel/repos/uriparser/test/FourSuite.h:41: undefined reference to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test/test.o:/home/joel/repos/uriparser/test/FourSuite.h:42: more undefined references to `Test::Suite::register_test(void (Test::Suite::*)(), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' follow
collect2: error: ld returned 1 exit status
Makefile:896: recipe for target 'test/uriparser_test' failed
make[2]: *** [test/uriparser_test] Error 1
make[2]: Leaving directory '/home/joel/repos/uriparser'
Makefile:1511: recipe for target 'check-am' failed
make[1]: *** [check-am] Error 2
make[1]: Leaving directory '/home/joel/repos/uriparser'
Makefile:1062: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

Thanks,

Joel

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [Uriparser-users] GCC warning patches

[Sebastian P. <seb...@pi...>]

Hi Joel,


On 28.11.2017 00:03, Cunningham, Joel wrote:
> Hi,
> 
> I have attached two patches to address -Werror-parentheses and -Werror-uninitialized issues found with GCC 4.9 and uriparser

thanks, applied both now.


> There are also instances of -Werror-missing-prototypes and -Werror-missing-declarations for the following functions (which don't seem to have declarations):
> 
> RemoveBaseUriImpl
> _TESTING_ONLY_ParseIpSix
> _TESTING_ONLY_ParseIpFour
> 
> Should RemoveBaseUriImpl be declared static since it's only referenced in UriShorten.c and declared at the top of the file?

Yes, made static now.

It's warning clean for GCC 5.4 with -Wextra here now.  I'm short on
time, but patches welcome to go beyond that.


> I'm not sure the use of the __TESTING_ONLY functions, maybe these should be local too?

The test suite needs these symbols so the build system would need some
adjustment if these become static.  Still need to fix the same in Expat
as well.  If you have a minute, patches are welcome.

Best



Sebastian

[Uriparser-users] GCC warning patches

[Cunningham, J. <Joe...@ga...>]

Hi,

I have attached two patches to address -Werror-parentheses and -Werror-uninitialized issues found with GCC 4.9 and uriparser

There are also instances of -Werror-missing-prototypes and -Werror-missing-declarations for the following functions (which don't seem to have declarations):

RemoveBaseUriImpl
_TESTING_ONLY_ParseIpSix
_TESTING_ONLY_ParseIpFour

Should RemoveBaseUriImpl be declared static since it's only referenced in UriShorten.c and declared at the top of the file? I'm not sure the use of the __TESTING_ONLY functions, maybe these should be local too?

Thanks,

Joel

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [Uriparser-users] Patch for GCC 4.9 -stdc=c90 -Werror=undef

[Sebastian P. <seb...@pi...>]

Hi Joel,


your patch is in Git now, thank you!

Excellent commit message by the way.

Best



Sebastian

[Uriparser-users] Patch for GCC 4.9 -stdc=c90 -Werror=undef

[Cunningham, J. <Joe...@ga...>]

Hi,

I'm building uriparser with GCC 4.9 -stdc=c90 -Werror=undef.  I'd like to submit the attached patch which corrects a minor issue of __STDC_VERSION__ not being defined for C90 mode.

Thanks,

Joel

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [Uriparser-users] Patch to build with ARMCC in C90 mode

[Sebastian P. <seb...@pi...>]

Hi Joel,


looks good, in Git now.  Thanks for the patch!

Best



Sebastian


On 15.06.2017 15:51, Cunningham, Joel wrote:
> Hi,
> 
> I've built uriparser with the ARM C Compiler (ARMCC) in its default C90 mode.  I only needed a single change to support this compiler (addressing declaration appearing after executable statement in block) and would be like to submit the change.
> 
> See attached patch, thanks!
> 
> Joel
> 
> ________________________________
> 
> CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.
> 
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> 
> 
> 
> _______________________________________________
> Uriparser-users mailing list
> Uri...@li...
> https://lists.sourceforge.net/lists/listinfo/uriparser-users
> 

[Uriparser-users] Patch to build with ARMCC in C90 mode

[Cunningham, J. <Joe...@ga...>]

Hi,

I've built uriparser with the ARM C Compiler (ARMCC) in its default C90 mode.  I only needed a single change to support this compiler (addressing declaration appearing after executable statement in block) and would be like to submit the change.

See attached patch, thanks!

Joel

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [Uriparser-users] [Tiny patch] Make the uriparse tool build on FreeBSD

[Sebastian P. <seb...@pi...>]

Hello Ed,


On 26.10.2015 20:40, Ed Schouten wrote:
> Hi Sebastian,
> 
> Hope you're doing fine!

it's been a while.  Hope you're well up too!


> While updating the FreeBSD port for uriparser to 0.8.4, I noticed that
> the uriparse command line tool doesn't seem to build. It uses the
> AF_INET and AF_INET6 constants, but those are only provided by
> <sys/socket.h> -- not <arpa/inet.h>.
> 
> Attached is a patch to fix the build on FreeBSD.

Thanks for the patch!

I have applied the patch in Git now.  If a dedicated release 0.8.4.1
would help, just let me know.

Best,



Sebastian

[Uriparser-users] [Tiny patch] Make the uriparse tool build on FreeBSD

[Ed S. <ed...@nu...>]

Hi Sebastian,

Hope you're doing fine!

While updating the FreeBSD port for uriparser to 0.8.4, I noticed that
the uriparse command line tool doesn't seem to build. It uses the
AF_INET and AF_INET6 constants, but those are only provided by
<sys/socket.h> -- not <arpa/inet.h>.

Attached is a patch to fix the build on FreeBSD.

Best regards,
-- 
Ed Schouten <ed...@nu...>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717

Re: [Uriparser-users] Two issues found by Coverity Scan

[Sebastian P. <seb...@pi...>]

Hello Robert,


On 02.10.2015 20:37, Robert Kausch wrote:
> I'm using libxspf and thus uriparser in my project and I'm regularly
> running my code through Coverity's Scan service which detected two
> potential issues in uriparser that I would like to share.

thanks for sharing the reports!  While minor, they did turn out to point
at real bugs.

I'd be curious what that libxspf depending project of yours is about.
Please drop me a private mail with details, if you are willing to share
some.


> One is a null pointer dereference issue in uriAddBaseUriImpl,

Fixed by:
https://sourceforge.net/p/uriparser/git/ci/e66e70b9aa415b15f192f702a7677060eec56b60/tree/src/UriCommon.c?diff=19fa552db69a7f944249cfa02725763ee5fde060


> the other
> a read after free error in uriMakeOwner.

Fixed by:
https://sourceforge.net/p/uriparser/git/ci/07d5a0ccb462b754e245290c7404f127f2bab08a/tree/src/UriNormalize.c?diff=c035376bab8098aa2bfc6d173fe3d456b5050c73


I just released 0.8.3 with both issues fixed.


Best,



Sebastian

[Uriparser-users] Two issues found by Coverity Scan

[Robert K. <rob...@fr...>]

Dear uriparser devs,

I'm using libxspf and thus uriparser in my project and I'm regularly 
running my code through Coverity's Scan service which detected two 
potential issues in uriparser that I would like to share.

One is a null pointer dereference issue in uriAddBaseUriImpl, the other 
a read after free error in uriMakeOwner. Please take a look at the 
attached files which are copies of the respective Coverity reports.

The reports might be false positives depending on what preconditions 
unknown to Coverity exist, but probably worth taking a look.

BR,
Robert

-- 
----
Robert Kausch
rob...@fr...

Re: [Uriparser-users] recomposing a URI

[Chuck L. <chu...@or...>]

On Jun 9, 2014, at 4:40 PM, Sebastian Pipping <seb...@pi...> wrote:

> Hi!
> 
> 
> On 09.06.2014 22:33, Chuck Lever wrote:
>> I need there to be two slashs at the end of the authority component,
>> always.
>> 
>> Starting the path component with an empty path segment does that, unless
>> the empty path segment is the _only_ segment in the path component.
>> 
>> How do I get “nfs://nfs-server.example.net//“ out of uriToStringA() ?
> 
> I would try two empty path segments for that case.  What does that give you?

It gives the correct result.  Thank you!

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com