Re: [upnp-sdk-dev] Maintenance and large file patch

[<tur...@ea...>]

in addition to my previous remarks, I saw one important problem :
the use of "off_t" in exported headers (upnp.h) : this will generate=
=20
problems, for example if a shared libupnp is compiled with 64 bits of=
f_t=20
(--enable-largefile, the default), but a program using it uses 32bits=
=20
offsets. For a more lengthy description and several solutions see her=
e :=20
http://ac-archive.sourceforge.net/largefile/index.html
The simplest solution is to use our own new type in the API (e.g.=
=20
typedef long long Upnp_Offset) and program accordingly in the=20
implementation (e.g. before calling seeko, check that the intended=
=20
offset can be represented in off_t, in case the library has been=20
compiled with 32bits offsets).
Another solution is to use off_t in the API, and check that a program=
=20
using it is compiled in the same mode as was the library.


Best regards,
    R=E9mi