From: Eric T. <eri...@un...> - 2006-03-09 17:50:49
|
Le mardi 07 mars 2006 =C3=A0 18:17 -0500, John Dennis a =C3=A9crit : > On Tue, 2006-03-07 at 22:42 +0100, Eric Tanguy wrote: > > John, the rpms for release 1.3.1 are already built for FC-3, FC-4 and > > devel as well as new version of ushare using it. If you want to own t= he > > package or submit a patch, don't hesitate! The only thing is that thi= s > > lib have to be compliant with ushare (the package which need it and > > that's why i did rpm for libupnp). Another question : redhat will > > include it in core or prefer to let it in extras ? >=20 > Excellent Eric! You're one step ahead of me again. The rpm looks > fabulous. The only thing that appears to be missing is the documentatio= n > and sample programs. These should probably go > in /usr/share/doc/libupnp-* >=20 > I don't think auto generated doc is terribly important, it would be nic= e > but not critical, but I do think including UPnP_Programming_Guide.pdf i= s > essential.=20 >=20 > Off the top of my head without any testing (I feel like I'm going to > regret my caviler suggestions which weren't tested :-) Something like > this should do the trick (Remi: since these seem to be tweaks to the > configure stuff perhaps it should be added at your end, or you may > prefer a different approach): >=20 > % in configure.ac add: >=20 > AC_ARG_WITH([docdir], AC_HELP_STRING([--with-docdir=3DDIR], > [where documentation is installed]), > [docdir=3D"$with_docdir"], > [docdir=3D"${datadir}/doc/${PACKAGE_NAME}-${PACKAGE_VERSION= }"]) >=20 > AC_SUBST(docdir) >=20 > % in upnp/doc/Makefile.am add: >=20 > docdir =3D @DOCDIR@ > doc_DATA =3D UPnP_Programming_Guide.pdf >=20 > % in upnp/Makefile.am add: >=20 > docdir =3D @DOCDIR@ > examplesdir =3D $(docdir)/examples > examples_DATA =3D $(upnp_tv_ctrlpt_SOURCES) $(upnp_tv_device_SOURCES) >=20 > (Note: examples_DATA probably also needs a Makefile utilizing > pkg-config) >=20 > Once all this is done Eric then I think all that needs to be done is to > just add the doc files to the %files section in the spec file. >=20 > If either of you prefers I do the work I'm happy to. >=20 > With respect to moving libupnp from extras to core that's a decision > which will be out there in the future a bit. At the moment our use of > this technology is experimental and not yet fundamental to the core > product (all of which is subject to change :-) >=20 Ok but i prefer to wait this will be included directly in the tarball. Wh= at do you think about this R=C3=A9mi ? Cheers, Eric |